Skip to content

Fix path expansion/storage #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amaslenn merged 2 commits into from
Apr 8, 2026
Merged

Fix path expansion/storage #864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32bc483
Fix path expansion/storage
amaslenn Mar 18, 2026
8e7b895
Merge branch 'main' into am/rm-4931725
amaslenn Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/cloudai/_core/installables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ def installed_path(self) -> Union[str, Path]:
"""Return the cached path or URL of the docker image."""
if self._installed_path:
return self._installed_path.absolute() if isinstance(self._installed_path, Path) else self._installed_path
local_image_path = Path(self.url)
if local_image_path.is_absolute() or self.url.startswith("."):
return local_image_path.absolute()
return self.url

@installed_path.setter
Expand Down
14 changes: 14 additions & 0 deletions tests/systems/slurm/test_installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,3 +368,17 @@ def test_mark_as_installed_local_container(slurm_system: SlurmSystem):
installer.mark_as_installed_one(docker_image)

assert docker_image.installed_path == local_image.absolute()


def test_mark_as_installed_duplicate_local_containers_preserve_local_path(slurm_system: SlurmSystem):
installer = SlurmInstaller(slurm_system)

local_image = Path("/tmp/local_image.sqsh")
first = DockerImage(url=str(local_image))
second = DockerImage(url=str(local_image))

result = installer.mark_as_installed([first, second])

assert result.success
assert first.installed_path == local_image
assert second.installed_path == local_image
Loading