Skip to content

Ko itn staging v1#391

Open
tbartley94 wants to merge 7 commits intomainfrom
ko_itn_staging_v1
Open

Ko itn staging v1#391
tbartley94 wants to merge 7 commits intomainfrom
ko_itn_staging_v1

Conversation

@tbartley94
Copy link
Member

@tbartley94 tbartley94 commented Mar 4, 2026

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Before your PR is "Ready for review"

Pre checks:

  • Have you signed your commits? Use git commit -s to sign.
  • Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • Remove import guards (try import: ... except: ...) if not already done.
  • If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • New Feature
  • Bugfix
  • Documentation
  • Test

If you haven't finished some of the above items you can still open "Draft" PR.

hmlee245 and others added 7 commits June 10, 2025 11:38
@hmlee245 @pre-commit-ci
Second draft of Korean Cardinal ITN (#284)
eddebf3 
* First draft of Korean Cardinal ITN

Sparrowhawk testing is not done yet.

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixing all the feedbacks

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* This reverts commit f893d89, reversing
changes made to 9f7e876.

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* third draft of korean ITN work. Mainly fixing minor issues and adding test cases

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: hmlee245 <hmlee245@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@hmlee245 @pre-commit-ci
Korean ITN Ordinal (#287)
2a4e05e 
* First draft of Korean Cardinal ITN

Sparrowhawk testing is not done yet.

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixing all the feedbacks

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* This reverts commit f893d89, reversing
changes made to 9f7e876.

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* third draft of korean ITN work. Mainly fixing minor issues and adding test cases

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* Commiting the first draft of Korean Ordinal ITN

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update after first Korean Ordinal ITN pull request review

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Deleting unnecessary data files and rules

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Adding decimal to the PR

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Adding counter suffixes for Korean ordinal and its test cases

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fixing minor comments error for newly added ordinal suffix

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: hmlee245 <hmlee245@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@hmlee245 @pre-commit-ci
Korean ITN Fraction (#305)
ded875e 
* First draft of Korean Cardinal ITN

Sparrowhawk testing is not done yet.

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixing all the feedbacks

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* This reverts commit f893d89, reversing
changes made to 9f7e876.

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* third draft of korean ITN work. Mainly fixing minor issues and adding test cases

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* Commiting the first draft of Korean Ordinal ITN

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update after first Korean Ordinal ITN pull request review

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Deleting unnecessary data files and rules

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Adding decimal to the PR

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Adding counter suffixes for Korean ordinal and its test cases

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fixing minor comments error for newly added ordinal suffix

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Adding Korean fraction ITN to the codes and raising a new PR

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: hmlee245 <hmlee245@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@hmlee245 @pre-commit-ci
Korean ITN Time (#317)
d6df472 
* First draft of Korean Cardinal ITN

Sparrowhawk testing is not done yet.

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixing all the feedbacks

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* This reverts commit f893d89, reversing
changes made to 9f7e876.

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* third draft of korean ITN work. Mainly fixing minor issues and adding test cases

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* Commiting the first draft of Korean Ordinal ITN

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update after first Korean Ordinal ITN pull request review

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Deleting unnecessary data files and rules

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Adding decimal to the PR

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Adding counter suffixes for Korean ordinal and its test cases

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fixing minor comments error for newly added ordinal suffix

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Adding Korean fraction ITN to the codes and raising a new PR

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* Adding Korean ITN Time

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Changes to time ITN and draft for date ITN

Signed-off-by: Hyunmin Lee <hyunminl@hyunminl-mlt.client.nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Adding money to the Korean ITN

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* Adding money to the Korean ITN

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Addition of telephone class, fixing time, money, date

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fixing minor changes from other class and addition of measure class

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Updating minor fixes on all semiotic class

Signed-off-by: hmlee245 <hmlee245@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: hmlee245 <hmlee245@gmail.com>
Signed-off-by: Hyunmin Lee <hyunminl@hyunminl-mlt.client.nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hyunmin Lee <hyunminl@hyunminl-mlt.client.nvidia.com>
@bbae0312 @pre-commit-ci
Korean ITN staging v1 updates (#387)
aaeab10 
* Korean ITN fixes

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix KO ITN decimal and money graph cleanup

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>

* Fix KO ITN decimal-money ambiguity

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@bbae0312 @pre-commit-ci
KO ITN fixes (MRC updates) (#390)
fc715c8 
* Korean ITN fixes

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix KO ITN decimal and money graph cleanup

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>

* Fix KO ITN decimal-money ambiguity

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix Korean ITN rules based on the feedback

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>
Signed-off-by: Jinwoo Bae <34386414+bbae0312@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@bbae0312
KO ITN fixes (MRC updates) (#390) (#394)
c55b7ab 
* Korean ITN fixes



* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix KO ITN decimal and money graph cleanup



* Fix KO ITN decimal-money ambiguity



* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix Korean ITN rules based on the feedback



* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tbartley94 @hmlee245 @bbae0312