Merged
Conversation
removed redundant info from config LS
* function to complete a job * and date is needed
* first * removed too much! put it back * shitty theme
Bumps [flatted](https://github.com/WebReflection/flatted) from 3.2.7 to 3.4.2. - [Commits](WebReflection/flatted@v3.2.7...v3.4.2) --- updated-dependencies: - dependency-name: flatted dependency-version: 3.4.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add confirmation modal for refreshInterval changes Prevent accidental changes to refreshInterval by tracking the last value and showing a confirmation modal whenever the observable is changed. A showRecklessModal helper is injected into the DOM (id: recklessModal) and requires the user to type "reckless" to confirm; onCancel reverts the observable to the previous value. Implementation uses bootstrap.Modal and creates/removes event handlers for confirm/cancel and the modal close button. * gated
Adjust dark-mode CSS for vehicle popup tasking list: add styling for team badge (.veh-pop__team-title .badge.bg-light) with darker background (#444), text and border tweaks; set explicit background for tasking items (.veh-pop__tasking-item, --no-job) to #383838; set muted text color to #b0b0b0; and update hover background to #434343 to improve contrast and consistency in dark mode.
* Batch job tasking fetch and debounce Add batched and debounced tasking fetches to reduce per-job API calls and bursts. main.js: introduce a 250ms debounced initial-load batch for newly filtered-in jobs, a periodic batch refresh (driven by config.refreshInterval) and timer management (start/restart). Job.js: remove per-job periodic refresh checks, add a SINGLE_FETCH_COOLDOWN_MS (10s) and make fetchTasking honor a force option to avoid redundant single-job requests right after batch updates. Team.js: gate fetchTasking against both last fetch time and last bulk refresh time, clear loading state when throttled, and make updateFromJson do defensive/no-op updates to avoid unnecessary observable writes. shared/BeaconClient/job.js: extend getTasking to accept single id or array of ids, build multi-JobIds parameters, and use paginated JSON fetch to return a unified Results array. Overall this reduces API traffic, prevents duplicate refreshes, and avoids unnecessary UI churn. * Missed one type * teams not refreshing after tasking * sector fuckery when just wanting to see all jobs * bad bar for sectors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces major improvements to how job and team tasking data is fetched and refreshed in the tasking UI, focusing on efficiency, scalability, and UI responsiveness. The changes implement debounced and batched fetching for newly visible jobs, periodic batch refreshes for stale jobs, and smarter updates when tasking status changes. Additionally, marker styling now updates live when job priority changes, and some code clean-up and UI improvements have been made.
Tasking Data Fetching and Refresh Improvements
main.js,scheduleInitialTaskingFetch,filteredJobs.subscribe) [1] [2]main.js,fetchBatchJobTasking,startBatchTaskingTimer,refreshInterval.subscribe) [1] [2] [3]Jobmodel, centralizing refresh logic in the main view model for efficiency and maintainability. (Job.js)Tasking Status and UI Consistency
main.js, various status update methods) [1] [2] [3] [4]main.js,filteredTeamsAgainstConfig.subscribe)Live Marker and UI Updates
jobMarker.js,syncMarkerStyle) [1] [2] [3]jobMarker.js) [1] [2]Miscellaneous Improvements and Cleanups
main.js,spotlightSearch.js) [1] [2] [3] [4]main.js) [1] [2]main.js)Job.js)These changes collectively make the tasking UI more performant, responsive, and maintainable, especially for large incident loads and frequent job/team updates.