Skip to content

Update objectsid logic 1051 #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Misha-Shvets wants to merge 37 commits into
base: dev
Choose a base branch
from
Open

Update objectsid logic 1051 #944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
f68764d
Add: New SID prefix and Group RID enums
Feb 20, 2026
ca79248
Add: Implement RID Manager and update object SID handling across the …
Feb 26, 2026
87d61c9
Refactor: Clean up join statement in get_directory_by_rid function
Feb 26, 2026
d030505
Refactor: Simplify object SID extraction and update RID Manager use c…
Feb 26, 2026
dd7642b
Refactor: Rename and update RID Manager setup method to inherit ACEs
Feb 26, 2026
83e3720
Update down_revision in Alembic migration to reflect new dependency
Feb 26, 2026
10109c2
Update test constants and modify test cases to use AsyncSession; adju…
Feb 27, 2026
3cc79dd
Refactor: Remove unused RID set check and enhance RID Manager functio…
Feb 27, 2026
50acfa7
Add: Introduce new pytest fixtures for RID Manager gateway and use ca…
Feb 27, 2026
062a9f6
Enhance: Update test_api_modify_dn_with_level_up to include session e…
Feb 27, 2026
6a03b77
Refactor: Replace ValueError with specific RID Manager exceptions for…
Mar 2, 2026
de2c4b2
Refactor: Introduce ObjectSIDUseCase and related gateways, enhancing …
Mar 6, 2026
e5bc127
fix
Mar 6, 2026
32865a7
Refactor: Simplify object SID handling in Directory class and update …
Mar 30, 2026
08cbecd
Update down_revision in Alembic migration to reflect new dependency
Mar 30, 2026
d30f7ca
Refactor: Update domain controller retrieval methods and enhance RID …
Mar 31, 2026
72f782e
Refactor: Remove unused domain controller OU retrieval and streamline…
Mar 31, 2026
6b444a0
Add: Introduce RID_OBJECT_SID_NOT_FOUND_ERROR exception and update Ob…
Mar 31, 2026
31be1ac
Update: Modify Directory name in setup_session to include '-test' suf…
Mar 31, 2026
f88592c
Update: Change Directory name in setup_session to append '-test' suff…
Mar 31, 2026
4f56163
Update: Remove '-test' suffix from Directory names in setup_session f…
Mar 31, 2026
af14d05
Add: Integrate RIDManagerUseCase into test_add_domain_controller for …
Mar 31, 2026
f35eee2
Refactor: Update ObjectSID and RIDSet handling to use directory IDs i…
Apr 7, 2026
8962316
Refactor: Update entity type handling in RIDManager and RIDSet use ca…
Apr 7, 2026
1c4516b
Update: Add entity_type_name for SYSTEM_CONTAINER_NAME in constants a…
Apr 7, 2026
a6ebd62
Enhance: Refactor setup_session to streamline domain controller and d…
Apr 7, 2026
f18a27d
Refactor: Streamline object SID retrieval and enhance RID Set handlin…
Apr 9, 2026
fa2e243
Refactor: Update RIDSetGateway initialization to include settings for…
Apr 9, 2026
cc2720a
Fix: Pass domain ID to create_domain_identifier in setup_session for …
Apr 9, 2026
45cec83
Enhance: Clear domain identifier and RID set caches in setup_session …
Apr 9, 2026
f5defe4
Enhance: Integrate existing RID set ID retrieval into test_add_domain…
Apr 9, 2026
b37b1ad
Refactor: Update add_domain_controller to utilize RID Set allocation …
Apr 10, 2026
f447d4e
Refactor: Simplify condition construction in SearchRequest by directl…
Apr 10, 2026
38768dc
Enhance: Update object SID handling in upgrade function to correctly …
Apr 10, 2026
b81ee10
Enhance: Refactor upgrade function to include parentId in directory s…
Apr 10, 2026
d11ed27
Enhance: Implement async checks for primary group membership in Modif…
Apr 10, 2026
5d3a4c6
Enhance: Introduce a new utility function to skip specific directory …
Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/alembic/versions/01f3f05a5b11_add_primary_group_id.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,9 @@ async def _add_primary_group_id(connection: AsyncConnection) -> None: # noqa: A
query = (
select(Directory)
.options(
selectinload(qa(Directory.groups)).selectinload(
qa(Group.directory),
),
selectinload(qa(Directory.groups))
.selectinload(qa(Group.directory))
.selectinload(qa(Directory.attributes)),
)
.where(
qa(Directory.entity_type_id).in_(entity_type_ids),
Expand Down
Loading
Loading