remove conditions

[rlcee]

No description provided.

[FNALbuild]

Hi @rlcee,
You have proposed changes to files in these packages:

• JobConfig

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for d1354e9: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

[FNALbuild]

☀️ The build tests passed at d1354e9.

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged d1354e9 at 9611c7a
build (prof)	✅	Log file. Build time: 08 min 46 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 0 files
clang-tidy	✅	0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at d1354e9 after being merged into the base branch at 9611c7a.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[oksuzian]

I'll review this pull request by first loading the PR details and its changes.Now let me check if there are other .fcl files in the repository that still contain ConditionsService references that might have been missed:Now let me check if there are other .fcl files in the repo that still reference ConditionsService to see if this cleanup is incomplete:Here's my review of PR #515 — "remove conditions" by @rlcee.

Summary

This is a straightforward cleanup PR with 1 commit, modifying 11 .fcl files. Every change is identical: it removes the ConditionsService line from the services block:

-   ConditionsService      : { conditionsfile : "Offline/ConditionsService/data/conditions_01.txt"      }

0 additions, 11 deletions across these files:

File	Category
JobConfig/extmon/extmonbeam_g4s2.fcl	ExtMon simulation
JobConfig/pbar/resample_vertex_s1.fcl	Antiproton simulation
JobConfig/pbar/resample_vertex_s2.fcl	Antiproton simulation
JobConfig/pbar/vertex_s0.fcl	Antiproton simulation
JobConfig/pbar/vertex_s1.fcl	Antiproton simulation
JobConfig/test/MuonTransport/MuonTransportSingleStage.fcl	Muon transport test
JobConfig/test/MuonTransport/MuonTransportStage1.fcl	Muon transport test
JobConfig/test/MuonTransport/MuonTransportStage2.fcl	Muon transport test
JobConfig/validation/mixPointsDump.fcl	Validation
JobConfig/validation/psEnclosureBeamWindow.fcl	Validation
JobConfig/validation/psEnclosureExtMonWindow.fcl	Validation

---

Potential Issues Found

1. ⚠️ Incomplete Removal — ConditionsService may still exist in other files

The search results show that the files modified in this PR are not the only files in the repository containing ConditionsService. Notably, JobConfig/pbar/vertex_s0.fcl still has ConditionsService on main but is not included in this PR's changes. If the goal is to remove all ConditionsService declarations from the repository, there may be additional files that were missed.

⚠️ Note: Search results are limited; there may be additional .fcl files containing ConditionsService. You can search for all remaining occurrences here.

2. ⚠️ No PR Description

The PR body is empty (null). For a change that removes a service configuration from 11 job config files, it would be helpful to have a description explaining:

• Why ConditionsService is being removed (is it deprecated? moved to a prolog/default? no longer needed by these jobs?)
• How was this validated — were these jobs tested without the ConditionsService to confirm they still run correctly?
• Whether the service is now provided by an #include'd file (e.g., Offline/fcl/standardServices.fcl) or is truly no longer needed.

3. ⚠️ Risk: Runtime Failures if ConditionsService Is Still Required

If any module used in these jobs (e.g., Mu2eG4, StepPointMCDumper, CompressPhysicalVolumes, etc.) still depends on ConditionsService at runtime, removing the explicit configuration could cause jobs to fail with a service-not-found error. This is the most significant risk. However, the PR label build finished suggests CI has run — it would be good to confirm whether the CI actually executes these job configs or only compiles.

4. ℹ️ Minor: resample_vertex_s2.fcl uses a different geometry path

In JobConfig/pbar/resample_vertex_s2.fcl, the GeometryService points to a different path compared to the other pbar files:

    GeometryService        : { inputFile      : "Production/JobConfig/cd3/geom_baseline.txt"    }

Other pbar files use "Production/JobConfig/common/geom_baseline.txt". This is pre-existing and not introduced by this PR, but worth noting as a potential inconsistency if this area is being cleaned up.

---

Verdict

The change itself is mechanically clean — each file has exactly one line removed with no side effects on surrounding code. The main concerns are:

1. Completeness — Are there other .fcl files that should also have ConditionsService removed?
2. Correctness — Is it confirmed that none of these jobs need ConditionsService at runtime (or that it's now provided via an included prolog)?
3. Documentation — A PR description explaining the motivation would be very helpful for reviewers.

[rlcee]

On copilot review, 1 would be interesting, but I think it is wrong, let me know if you see what it is talking about. 2, 3, and 4 are not relevant in the bigger picture. Seems this missing bigger picture is often a weakness. It could be helped by a AI-targeted PR description