Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project’s Node/tooling and cryptography dependencies, migrating the build/test/lint stack away from TSDX/Jest/legacy ESLint config toward Bunchee/Vitest/ESLint flat config, and adapting source/tests to updated @noble/* module entrypoints and byte APIs.
Changes:
- Replace TSDX build and Jest test setup with Bunchee build scripts and Vitest configuration.
- Upgrade major dependencies (notably
@noble/*,uuid,serialize-javascript, TypeScript/ESLint toolchain) and adjust imports/API usage accordingly. - Update crypto/polyfill and utility code to align with newer
@noble/*byte handling and Point APIs.
Reviewed changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vitest.config.js | Adds Vitest config (node env, axios alias, setup files). |
| tsdx.config.js | Removes TSDX rollup customization. |
| test/forge.test.ts | Updates @noble/* imports to .js entrypoints. |
| test/crypto.ts | Updates test crypto setup to define globalThis.crypto. |
| src/webview/client.ts | Removes inline eslint suppression on prompt. |
| src/client/utils/uniq.ts | Updates noble hash imports and normalizes inputs to Uint8Array. |
| src/client/utils/safe.ts | Updates ed25519 usage to match new noble byte expectations and point serialization. |
| src/client/utils/pin.ts | Updates ed25519/aes imports and shared secret/signing byte conversions. |
| src/client/utils/encoder.ts | Minor expression parenthesization tweak. |
| src/client/utils/ed25519.ts | Refactors to new noble curves APIs (Point/Fn/utils) and byte conversions. |
| src/client/utils/auth.ts | Updates ed25519 signing call to use byte arrays and hex key decoding. |
| src/client/types/client.ts | Formatting-only change to RequestConfig type. |
| src/blaze/utils.ts | Simplifies catch (e) to catch where error is intentionally ignored. |
| package.json | Raises Node engine requirement, switches scripts to Bunchee/Vitest, updates deps/devDeps, adjusts size limits, removes Jest config block. |
| jest.config.js | Removes Jest config. |
| eslint.config.js | Adds ESLint flat config replacing legacy .eslintrc*/ignore files. |
| babel.config.js | Removes Babel test config (Jest-related). |
| .eslintrc.js | Removes legacy ESLint config. |
| .eslintignore | Removes legacy ignore file (handled via flat config). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
package.json
Outdated
| ], | ||
| "engines": { | ||
| "node": ">=10" | ||
| "node": ">=20.19.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.