Skip to content

GEOPY-2776: Relabel uijson for TEM using Vertical, inLine, cross-line#368

Open
domfournier wants to merge 5 commits intodevelopfrom
GEOPY-2776
Open

GEOPY-2776: Relabel uijson for TEM using Vertical, inLine, cross-line#368
domfournier wants to merge 5 commits intodevelopfrom
GEOPY-2776

Conversation

@domfournier
Copy link
Copy Markdown
Collaborator

@domfournier domfournier commented Mar 31, 2026

GEOPY-2776 - Relabel uijson for TEM using Vertical, inLine, cross-line

Copilot AI review requested due to automatic review settings March 31, 2026 19:09
@github-actions github-actions bot changed the title GEOPY-2776 GEOPY-2776: Relabel uijson for TEM using Vertical, inLine, cross-line Mar 31, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes EM receiver component naming from legacy x/y/z to crossline/inline/vertical across TDEM/FDEM options, UI JSON labels/tooltips, receiver construction, and run tests to better align with survey-relative component terminology.

Changes:

  • Renames/aliases TDEM & FDEM option fields to vertical/inline/crossline variants using Pydantic AliasChoices.
  • Updates receiver orientation handling to translate vertical/inline/crossline into SimPEG’s z/y/x orientation codes.
  • Updates run tests and UI JSON labels/tooltips to use the new component naming.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/run_tests/oriented_airborne_tem_receiver_test.py Updates expected component group names to vertical/inline/crossline.
tests/run_tests/oriented_airborne_fem_receiver_test.py Updates expected component group names to vertical/inline/crossline.
tests/run_tests/driver_airborne_tem_test.py Updates test data/group naming and lookups to vertical.
tests/run_tests/driver_airborne_tem_1d_test.py Updates test data/group naming and lookups to vertical.
tests/run_tests/driver_airborne_fem_test.py Updates test data/group naming and lookups to vertical_*.
tests/run_tests/driver_airborne_fem_1d_test.py Updates test data/group naming and lookups to vertical_*.
simpeg_drivers/electromagnetics/time_domain/options.py Introduces vertical/inline/crossline option fields with aliases (but contains aliasing bugs).
simpeg_drivers/electromagnetics/time_domain_1d/options.py Adds vertical_* aliases for 1D TDEM options.
simpeg_drivers/electromagnetics/frequency_domain/options.py Adds vertical/inline/crossline aliases for FDEM options.
simpeg_drivers/electromagnetics/frequency_domain_1d/options.py Adds vertical_* aliases for 1D FDEM options.
simpeg_drivers/components/factories/receiver_factory.py Maps vertical/inline/crossline to z/y/x when building SimPEG receivers.
simpeg_drivers/components/data.py Simplifies TDEM dB/dt normalization initialization to a full -1 array.
simpeg_drivers-assets/uijson/tdem1d_inversion.ui.json Updates labels/tooltips to “Vertical”.
simpeg_drivers-assets/uijson/tdem1d_forward.ui.json Updates labels/tooltips to “Vertical”.
simpeg_drivers-assets/uijson/tdem_inversion.ui.json Updates labels/tooltips and swaps displayed meanings for x/y to crossline/inline.
simpeg_drivers-assets/uijson/tdem_forward.ui.json Updates component labels/tooltips to Vertical/In-line/Cross-line.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 95.83333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.85%. Comparing base (781475a) to head (8c0bf74).

Files with missing lines Patch % Lines
simpeg_drivers/plate_simulation/match/driver.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #368      +/-   ##
===========================================
- Coverage    89.85%   89.85%   -0.01%     
===========================================
  Files          125      125              
  Lines         6419     6424       +5     
  Branches       793      793              
===========================================
+ Hits          5768     5772       +4     
- Misses         448      449       +1     
  Partials       203      203              
Files with missing lines Coverage Δ
simpeg_drivers/components/data.py 93.08% <100.00%> (+0.45%) ⬆️
...g_drivers/components/factories/receiver_factory.py 89.90% <100.00%> (+0.09%) ⬆️
...ivers/electromagnetics/frequency_domain/options.py 94.36% <100.00%> (ø)
...rs/electromagnetics/frequency_domain_1d/options.py 100.00% <100.00%> (ø)
...eg_drivers/electromagnetics/time_domain/options.py 100.00% <100.00%> (ø)
...drivers/electromagnetics/time_domain_1d/options.py 100.00% <100.00%> (ø)
simpeg_drivers/plate_simulation/match/driver.py 83.09% <50.00%> (-0.72%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants