Skip to content

GEOPY-2770: Consolidate code for plate model definition between different repos#192

Merged
domfournier merged 6 commits intodevelopfrom
GEOPY-2770
Apr 6, 2026
Merged

GEOPY-2770: Consolidate code for plate model definition between different repos#192
domfournier merged 6 commits intodevelopfrom
GEOPY-2770

Conversation

@benk-mira
Copy link
Copy Markdown
Contributor

@benk-mira benk-mira commented Apr 6, 2026

GEOPY-2770 - Consolidate code for plate model definition between different repos

Copilot AI review requested due to automatic review settings April 6, 2026 16:26
@github-actions github-actions bot changed the title Geopy 2770 GEOPY-2770: Consolidate code for plate model definition between different repos Apr 6, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the plate modelling utilities to support dip_direction as an alias for direction, and introduces a higher-level Plate helper for masking and creating a geoh5py.Surface representation.

Changes:

  • Refactors PlateModel fields to use easting/northing/elevation and adds dip_direction alias support for direction.
  • Adds a Plate class with mask() and surface() helpers plus vertex/triangle generation.
  • Adds a unit test validating direction/dip_direction alias behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
geoapps_utils/modelling/plates.py Refactors PlateModel API and adds new Plate geometry/masking utilities.
tests/plates_test.py Adds coverage for directiondip_direction aliasing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

❌ Patch coverage is 51.21951% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.86%. Comparing base (eb04741) to head (e9065bc).
⚠️ Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
geoapps_utils/modelling/plates.py 51.21% 20 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #192      +/-   ##
===========================================
- Coverage    86.14%   84.86%   -1.28%     
===========================================
  Files           19       19              
  Lines         1126     1163      +37     
  Branches       151      151              
===========================================
+ Hits           970      987      +17     
- Misses         116      136      +20     
  Partials        40       40              
Files with missing lines Coverage Δ
geoapps_utils/modelling/plates.py 69.23% <51.21%> (-30.77%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@domfournier domfournier merged commit f0289a8 into develop Apr 6, 2026
20 checks passed
@domfournier domfournier deleted the GEOPY-2770 branch April 6, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants