Conversation
|
@okramarenko : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
prmerger-automator
bot
added
Change sent to author
powerquery/svc
get-data/subsvc
labels
|
Learn Build status updates of commit dea100b:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| powerquery-docs/connectors/singlestore.md | Details | ||
| powerquery-docs/connectors/includes/singlestore-capabilities-supported.md | ✅Succeeded | ||
| powerquery-docs/connectors/index.md | ✅Succeeded | ||
| powerquery-docs/connectors/media/singlestore/ss-db-select-mode.png | ✅Succeeded | ||
| powerquery-docs/native-database-query.md | ✅Succeeded |
powerquery-docs/connectors/singlestore.md
- Line 79, Column 10: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/power-query/native-database-query#limitations-and-issues' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. - Line 79, Column 10: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/power-query/native-database-query#limitations-and-issues' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
There was a problem hiding this comment.
Pull request overview
Updates the SingleStore Power BI connector documentation to reflect support for NativeQuery/native database query functionality and aligns the connector’s listing/state across the docs.
Changes:
- Add SingleStore to the global “connectors that support native database queries” list.
- Update the SingleStore connector page with native query connection instructions, limitations, and an updated connection dialog screenshot.
- Remove the “(Beta)” label from SingleStore in the connectors index and update the SingleStore capabilities include.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| powerquery-docs/native-database-query.md | Adds SingleStore to the table of connectors supporting native database queries. |
| powerquery-docs/connectors/singlestore.md | Documents the native query option in the connection flow and adds a limitations section; updates Kerberos link and wording. |
| powerquery-docs/connectors/media/singlestore/ss-db-select-mode.png | Updates/adds the screenshot used for the connection configuration dialog. |
| powerquery-docs/connectors/index.md | Removes “(Beta)” from the SingleStore connector entry. |
| powerquery-docs/connectors/includes/singlestore-capabilities-supported.md | Adds “Advanced options → Native SQL statement” to capabilities supported. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## Limitations of Native Database Queries | ||
|
|
||
| 5. If you've worked with the data set before and it's cached in memory, refresh the report to reset the local cache. On the **Home** ribbon, select **Refresh**. | ||
| * To create a custom SQL report using the connector, the user must only have read-only access to the SingleStore databases. |
There was a problem hiding this comment.
This limitations section is about native database queries, but the first bullet still talks about creating a "custom SQL report". Consider rephrasing to explicitly refer to running/creating a native database query (or clearly distinguishing it from the legacy CustomSQL/SingleStoreODBC.Query path) so readers don't conflate the two.
| * To create a custom SQL report using the connector, the user must only have read-only access to the SingleStore databases. | |
| * To run a native database query using the connector, the user must only have read-only access to the SingleStore databases. |
| * DirectQuery (Power BI semantic models) | ||
|
|
||
| * Advanced options | ||
| - Native SQL statement |
There was a problem hiding this comment.
In this capabilities include, the nested list under "Advanced options" uses a - bullet while other connector capability includes use * bullets for nested items. For consistency (and to avoid unexpected rendering differences), switch the nested bullet to match the established * style.
| - Native SQL statement | |
| * Native SQL statement |
| * **Server**: Enter the IP address or the hostname of the SingleStore cluster. | ||
| * **Database**: Enter the name of the SingleStore database to connect with. | ||
| * **Data Connectivity mode**: Select **Import** or **DirectQuery**. | ||
| * (Optional) To ingest data using a native database query, enter the SQL query in the **Native query** box. |
There was a problem hiding this comment.
The docs use two different labels for the same feature: this step refers to the Native query box, while the capabilities section calls it "Native SQL statement". Please align the terminology with the actual UI label used by this connector (and keep it consistent across the page and include) to reduce user confusion.
| * (Optional) To ingest data using a native database query, enter the SQL query in the **Native query** box. | |
| * (Optional) To ingest data using a native database query, enter the SQL query in the **Native SQL statement** box. |
|
Learn Build status updates of commit b1dbed6:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| powerquery-docs/connectors/singlestore.md | Details | ||
| powerquery-docs/connectors/includes/singlestore-capabilities-supported.md | ✅Succeeded | ||
| powerquery-docs/connectors/index.md | ✅Succeeded | ||
| powerquery-docs/connectors/media/singlestore/ss-db-select-mode.png | ✅Succeeded | ||
| powerquery-docs/native-database-query.md | ✅Succeeded |
powerquery-docs/connectors/singlestore.md
- Line 79, Column 10: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/power-query/native-database-query#limitations-and-issues' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. - Line 79, Column 10: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/power-query/native-database-query#limitations-and-issues' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
Hi there! This PR updates the SingleStore Power BI connector docs to include the newly added NativeQuery functionality.