Skip to content

chore(network-enablement-controller): replace Sinon with Jest fake timers#7971

Merged
cryptodev-2s merged 1 commit intomainfrom
chore/network-enablement-controller-replace-sinon-with-jest
Feb 18, 2026
Merged

chore(network-enablement-controller): replace Sinon with Jest fake timers#7971
cryptodev-2s merged 1 commit intomainfrom
chore/network-enablement-controller-replace-sinon-with-jest

Conversation

@cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Feb 18, 2026

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Test-only and dependency cleanup change; main risk is subtle timing differences causing flaky tests rather than runtime behavior changes.

Overview
Removes sinon from @metamask/network-enablement-controller dev dependencies and updates the lockfile accordingly.

Migrates NetworkEnablementController.test.ts from Sinon fake timers to Jest fake timers by switching setup/teardown to jest.useFakeTimers()/jest.useRealTimers() and replacing advanceTime({ clock, ... }) calls with jestAdvanceTime(...).

Written by Cursor Bugbot for commit 5a5d726. This will update automatically on new commits. Configure here.

@cryptodev-2s cryptodev-2s force-pushed the chore/network-enablement-controller-replace-sinon-with-jest branch from 52106ed to bbcac66 Compare February 18, 2026 12:32
@cryptodev-2s cryptodev-2s marked this pull request as ready for review February 18, 2026 12:33
@cryptodev-2s cryptodev-2s requested review from a team as code owners February 18, 2026 12:33
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@cryptodev-2s cryptodev-2s force-pushed the chore/network-enablement-controller-replace-sinon-with-jest branch from bbcac66 to 5a5d726 Compare February 18, 2026 12:36
@cryptodev-2s cryptodev-2s changed the title chore(network-enablement-controller): replace Sinon with Jest fake ti… chore(network-enablement-controller): replace Sinon with Jest fake timers Feb 18, 2026
@cryptodev-2s cryptodev-2s changed the title chore(network-enablement-controller): replace Sinon with Jest fake timers chore(network-enablement-controller): replace Sinon with Jest fake timers Feb 18, 2026
@cryptodev-2s cryptodev-2s added this pull request to the merge queue Feb 18, 2026
Merged via the queue into main with commit 85f5beb Feb 18, 2026
306 checks passed
@cryptodev-2s cryptodev-2s deleted the chore/network-enablement-controller-replace-sinon-with-jest branch February 18, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants