chore(network-enablement-controller): replace Sinon with Jest fake timers#7971
Merged
cryptodev-2s merged 1 commit intomainfrom Feb 18, 2026
Merged
Conversation
52106ed to
bbcac66
Compare
packages/network-enablement-controller/src/NetworkEnablementController.test.ts
Show resolved
Hide resolved
bbcac66 to
5a5d726
Compare
Sinon with Jest fake timers
salimtb
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Low Risk
Test-only and dependency cleanup change; main risk is subtle timing differences causing flaky tests rather than runtime behavior changes.
Overview
Removes
sinonfrom@metamask/network-enablement-controllerdev dependencies and updates the lockfile accordingly.Migrates
NetworkEnablementController.test.tsfrom Sinon fake timers to Jest fake timers by switching setup/teardown tojest.useFakeTimers()/jest.useRealTimers()and replacingadvanceTime({ clock, ... })calls withjestAdvanceTime(...).Written by Cursor Bugbot for commit 5a5d726. This will update automatically on new commits. Configure here.