Skip to content

chore(polling-controller): replace Sinon with Jest fake timers#7966

Merged
cryptodev-2s merged 1 commit intomainfrom
chore/polling-controller-replace-sinon-with-jest
Feb 18, 2026
Merged

chore(polling-controller): replace Sinon with Jest fake timers#7966
cryptodev-2s merged 1 commit intomainfrom
chore/polling-controller-replace-sinon-with-jest

Conversation

@cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Feb 17, 2026

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Test-only refactor plus dependency removal; main risk is subtle timer-behavior differences causing flaky or changed test outcomes.

Overview
Test timing in @metamask/polling-controller is migrated from Sinon to Jest: Sinon is removed from devDependencies, tests now use jest.useFakeTimers()/jest.useRealTimers(), and interval-based assertions in StaticIntervalPollingController.test.ts advance time via the shared jestAdvanceTime helper.

yarn.lock is updated accordingly to drop the sinon dependency.

Written by Cursor Bugbot for commit c94eda7. This will update automatically on new commits. Configure here.

@cryptodev-2s cryptodev-2s self-assigned this Feb 17, 2026
@cryptodev-2s cryptodev-2s requested a review from a team as a code owner February 17, 2026 21:30
@cryptodev-2s cryptodev-2s force-pushed the chore/polling-controller-replace-sinon-with-jest branch from 05b5241 to c94eda7 Compare February 18, 2026 12:50
@cryptodev-2s cryptodev-2s added this pull request to the merge queue Feb 18, 2026
Merged via the queue into main with commit 6d06834 Feb 18, 2026
306 checks passed
@cryptodev-2s cryptodev-2s deleted the chore/polling-controller-replace-sinon-with-jest branch February 18, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants