Option to check whole repository/directory#180
Open
r-sharp wants to merge 14 commits intoMetOffice:mainfrom
Open
Option to check whole repository/directory#180r-sharp wants to merge 14 commits intoMetOffice:mainfrom
r-sharp wants to merge 14 commits intoMetOffice:mainfrom
Conversation
… ToDo plugin work nicely.
This was referenced Feb 9, 2026
Open
MetOffice#173) * Tweaks to get VSCode's internal linters to quit whinging and make the ToDo plugin work nicely. * Touch O Tidying and ToDo commenting. * reviewer request to Update script_umdp3_checker/umdp3_conformance.py Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com> * Update script_umdp3_checker/umdp3_checker_rules.py Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com> * Update script_umdp3_checker/umdp3_checker_rules.py Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com> * Update script_umdp3_checker/umdp3_checker_rules.py Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com> * Update script_umdp3_checker/umdp3_checker_rules.py Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com> * Update script_umdp3_checker/umdp3_checker_rules.py Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com> * Rreviwer requested changes that I was unable to commit via GitHub's web interface --------- Co-authored-by: Pierre Siddall <43399998+Pierre-siddall@users.noreply.github.com> Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com>
Pierre-siddall
requested changes
Feb 12, 2026
Contributor
Pierre-siddall
left a comment
There was a problem hiding this comment.
Semantically speaking this mostly looks good to head onto code review for me. I just have a couple of really tiny suggestions when it comes to documentation and allocating a small amount of redundant memory. If the checkers array is a placeholder to prompt you later on feel free to leave it there, but I thought I'd flag it as I was unsure of it's intent.
Co-authored-by: Pierre Siddall <43399998+Pierre-siddall@users.noreply.github.com>
Co-authored-by: Pierre Siddall <43399998+Pierre-siddall@users.noreply.github.com>
Pierre-siddall
approved these changes
Feb 16, 2026
Contributor
Pierre-siddall
left a comment
There was a problem hiding this comment.
Thanks Roddy, this now looks good to head onto code review to me :) .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: @Pierre-siddall
Code Reviewer: @jennyhickson
A change to add a command line argument whichrather than checking with a CMS for a list of changed files, uses glob to assemble a list of all files within a direcotry (or local repository clone)
As such, adds a block for the new, logical, argument.
Creates a new subroutine to decide whether to ask a CMS or use glob.
Refactors the bit that used to output info about the branch and the files found to within the routine that decides which CMS to use before passing the CMS object back to the new routine which creates the list of files to check.
Which was a pre-requisite, now merged.
Still stacking those PRs
Code Quality Checklist
Testing
Change run, on command line of VDI, against other peoples ukca and um branches both with and without
--fullcheck. The results were as expected.Security Considerations
AI Assistance and Attribution
AI used (GitHub Copilot) as it is enabled to provide inline hinting and completion. It's responsibe for those two horrendously verbose (by even my standards) docstrings, which I accepted purely for amusment's sake.
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review