Fixed windows photo attachment and refactored input functions#4310
Open
gabriel-bolbotina wants to merge 10 commits intomasterfrom
Open
Fixed windows photo attachment and refactored input functions#4310gabriel-bolbotina wants to merge 10 commits intomasterfrom
gabriel-bolbotina wants to merge 10 commits intomasterfrom
Conversation
📦 Build Artifacts Ready
|
Withalion
reviewed
Feb 13, 2026
Contributor
Withalion
left a comment
Withalion
left a comment
There was a problem hiding this comment.
Nice this will be great UX improvement. Just a few bits here and there, which I'm not sure myself
Contributor
|
In testing we should also check if it fixes: |
📦 Build Artifacts Ready
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for review.
Modified the image paths in components that used them from 'file://' to 'file:///', which works on all the platforms, both Windows and Unix based.
I refactored the input functions that deal with paths to better accommodate system based differences for handling paths (e.g., partition letters on Windows). Also, I tried to use QDir and QFileInfo as much as possible.
Tested adding, viewing and saving photos on:
video-window-photo-fix.mov
Also ran the testUtils and testSketching on Windows as well.