avoid accumulating copies of event handlers when reattaching#15
Open
leofidus wants to merge 1 commit intoMarshallOfSound:masterfrom
Open
avoid accumulating copies of event handlers when reattaching#15leofidus wants to merge 1 commit intoMarshallOfSound:masterfrom
leofidus wants to merge 1 commit intoMarshallOfSound:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into the same issue as #3 (did-attach firing again after setting a surrounding container display:none, then display: block). The simplest fix seemed to be to just not add the events again if we did it once before. All this commit does is add the if statement to accomplish that.