feat: Add test_connection/1 for Syslog#3333
Open
ruslandoga wants to merge 4 commits intoLogflare:mainfrom
Open
feat: Add test_connection/1 for Syslog#3333ruslandoga wants to merge 4 commits intoLogflare:mainfrom
test_connection/1 for Syslog#3333ruslandoga wants to merge 4 commits intoLogflare:mainfrom
Conversation
ruslandoga
force-pushed
the
rd/syslog-test_connection
branch
from
33bc998 to
f2a2dff
Compare
ruslandoga
commented
Apr 4, 2026
| import BetterStackLogs from "./syslog/03_betterstack_logs.png"; | ||
| import LogflareTestConnection from "./syslog/02_logflare_test_connection.png"; | ||
| import LogflareEnableBackend from "./syslog/03_logflare_enable_backend.png"; | ||
| import BetterStackLogs from "./syslog/04_betterstack_logs.png"; |
Contributor
Author
There was a problem hiding this comment.
I've also tinified the images a bit more.
ruslandoga
commented
Apr 4, 2026
|
|
||
| import Kernel, except: [send: 2] | ||
| alias Logflare.Backends.Cache, as: BackendsCache | ||
| alias Logflare.Backends.Adaptor.SyslogAdaptor.Socket |
Contributor
Author
There was a problem hiding this comment.
I've extracted all socket-related logic into a separate module.
ruslandoga
commented
Apr 4, 2026
| @impl Logflare.Backends.Adaptor | ||
| def test_connection(backend) do | ||
| result = | ||
| with {:ok, socket} <- Socket.connect(backend.config, to_timeout(second: 3)) do |
Contributor
Author
There was a problem hiding this comment.
Using a shorter timeout since it's a user action.
ruslandoga
commented
Apr 4, 2026
ruslandoga
changed the title
test_connection/1 for Syslogtest_connection/1 for Syslog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
test_connection/1callback to the Syslog backend and updates the Better Stack integration guide. I've also extracted the socket functions into a separate module that's now used both from the pool and the newtest_connection/1.