Open
Conversation
Fixes step 5/10 enable/disable
Changing mode from auto to manual would require the program to stop and just gives unneccesary warnings when trying it anyway
Author
|
I just fixed an other issue: Jogging while a program is running always gave an error. There is no reason to try to change to manual mode when the mode is auto. |
Author
|
I tested in Mach3 in a Windows VM with the original plugin from https://www.cdxhctech.com/html/edownloads/view_420.html and the display also doesn't show any spindle speed or feed. So I think might be a firmware bug of my device. So I leave that for now. I created a back-port to the latest release if someone (like me) doesn't want to test all new changes on his new CNC: https://github.com/hdiethelm/linuxcnc-fork/tree/xhc-whb04b-6-fix-v2_backport-v2.9.8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
I'm pretty new to LinuxCNC, just finalizing my new CNC mill. I hope this PR matches your expectations. Otherwise, just tell me.
I fixed some issues in the xhc-whb04b-6 component:
Somehow, also the Spindle and Feed values are not shown on the display. I was not able to fix this until now. If I find the issue, I will create a separate PR.