Adding auto build and publish in pipy#8
Open
einar-lanfranco wants to merge 2 commits intoLeakIX:mainfrom
Open
Conversation
Contributor
|
Hi @einar-lanfranco! Thanks for your contribution! I highly appreciate the time you spent. However, I have been thinking about the security aspect of publishing automatically to pypi using GH Actions, in particular following the recent security issue that happened with Ledger and connect-kit. I would prefer to not do it. We are strict on security at LeakIX, and we want to restrict the rights to publish our packages available to the community. Regarding your changes with flake, I am in favor of adding it. However, can you add in the poetry config file instead please? Regarding the description missing on pypi, it is because the file pyproject.toml does not reference the README and other information, see the doc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Danny, this is what i use to build and publish the packager to pipy, you just need to add the api token from pipy to a Repository secrets in Settings -> Secrets and Variables -> Actions.
I use it in python-publis.yml in .github/workflows -> password: ${{ secrets.api_de_pip }}
And then: every time you push to main the python packages is built and every time you tag in github it automatically publish in pipy
Let me konw if it helps.
Note: When you are going to tag you need to update version in setup.py also to keep sync the pipy documentation.