Skip to content

Share instrument annotations across QC folders#1183

Open
ankurjuneja wants to merge 15 commits intodevelopfrom
fb_shareAnnotations
Open

Share instrument annotations across QC folders#1183
ankurjuneja wants to merge 15 commits intodevelopfrom
fb_shareAnnotations

Conversation

@ankurjuneja
Copy link
Contributor

Rationale

Panorama users want to record changes to the system (MP, SSTs, columns, PMs, etc) via the Annotations features and having them in separate folders requires them to add the Annotations to both even though it is the same system.
This will simplify the need by adding the shared annotations for the same instrument across multiple QC folders.

Related Pull Requests

Changes

  • Add new columns to QCAnnotation and QCAnnotationType tables
  • Associate shared annotations with instrument of the QC folder
  • Display shared annotations in qc folders with same instruments across server

@ankurjuneja
Copy link
Contributor Author

@labkey-jeckels should this go in 26.3 or develop as it has a sql upgrade script?

@labkey-jeckels
Copy link
Contributor

@labkey-jeckels should this go in 26.3 or develop as it has a sql upgrade script?

26.3 please. We get ourselves in trouble when we have upgrade scripts in multiple active branches.

I'll wait to review until you've had a chance to update the target branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants