Open
Conversation
labkey-matthewb
approved these changes
Mar 20, 2026
| put("server.compression.enabled", "true"); | ||
| // Spring Boot compresses HTML, JSON and other types by default, but not TSV. We have to duplicate the | ||
| // defaults and add text/tab-separated-values | ||
| put("server.compression.mime-types", "text/html,text/xml,text/plain,text/css,text/javascript,application/javascript,application/json,application/xml,text/tab-separated-values"); |
Contributor
There was a problem hiding this comment.
I see one use of text/json in our code, but I don' think we're using that in responses.
Contributor
There was a problem hiding this comment.
I do not think text/json is a valid mime-type. It should only be application/json according to RFC8259.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Spring Boot compresses many text HTTP responses by default. But not TSV.
Changes
text/tab-separated-valuesto the default set of compressed MIME types