GitHub 895: Search: Over indexing Assay Batch#7494
Merged
cnathe merged 4 commits intorelease26.3-SNAPSHOTfrom Mar 17, 2026
Merged
GitHub 895: Search: Over indexing Assay Batch#7494cnathe merged 4 commits intorelease26.3-SNAPSHOTfrom
cnathe merged 4 commits intorelease26.3-SNAPSHOTfrom
Conversation
…ltering to prevent indexing all batches for an assay protocol for all containers in scope
labkey-nicka
approved these changes
Mar 16, 2026
Contributor
labkey-nicka
left a comment
labkey-nicka
left a comment
There was a problem hiding this comment.
Looks good. Manually tested some scenarios and it seems to be indexing batches appropriately as it pertains to this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
https://github.com/LabKey/internal-issues/issues/895
When enumerating documents for search, we are getting all in-scope assay protocols for a given container (which includes the current container plus project and shared containers). We are then getting all assay batches for those protocols and indexing them. This means that for every container where an assay protocol is in-scope, all assay batches for that protocol are getting indexed. This PR updates that to do the same as the assay run document provider and filter the "get runs" call to just those assay runs in the given container.
Changes