Empty line with mvtc column should be treated as empty line#7493
Merged
Empty line with mvtc column should be treated as empty line#7493
Conversation
| // GitHub Issue 925: Not providing a MVTC value in an assay result throws error | ||
| // convert blank to empty array, not null | ||
| values[i] = column.converter.convert(column.clazz, fld); | ||
| if (values[i] instanceof MultiChoice.Array array) |
Contributor
There was a problem hiding this comment.
Is there value is making this more generic? instanceof List and/or instanceof java.sql.Array?
labkey-matthewb
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Blank MVTC will be parsed as empty array [] during import. This resulted in blank row being treated as a nonblank row with non-null MVTC field. Empty MV array should not flag a line as non blank.
SMSampleTypeMultiChoiceTest & SMSourceTypeMultiChoiceTest
Extra lines in the Excel file are creating unexpected rows during import.
Related Pull Requests
Changes