Open
Conversation
Replace the compile-time `nassau` feature flag with a single `QueryModuleResolution` enum that dispatches to either the standard or Nassau algorithm at runtime. Key changes: - `nassau::Resolution` no longer has a type parameter; it now uses `SteenrodAlgebra`/`CCC` types externally, matching the standard resolution's associated types. A `milnor_algebra()` helper extracts `&MilnorAlgebra` internally for algorithm-specific operations. - `QueryModuleResolution` enum (Standard/Nassau) implements `ChainComplex` and `AugmentedChainComplex` via a `delegate!` macro, picking up the `FreeChainComplex` blanket impl automatically. - `construct()` auto-detects Nassau when: Milnor basis, p=2, finite dimensional module, no profile, no cofiber, and a save directory is provided. Without a save directory, standard is used to preserve in-memory quasi-inverse support for `ResolutionHomomorphism` and `SecondaryResolution`. - All `#[cfg(feature = "nassau")]` blocks removed from examples and utilities. - Nassau benchmark files deleted (standard benchmarks now cover them). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nassaufeature flag with aQueryModuleResolutionenum that dispatches to the standard or Nassau algorithm at runtimenassau::Resolutionnow usesSteenrodAlgebra/CCCtypes externally (matching the standard resolution's associated types), with amilnor_algebra()helper for internal algorithm operationsconstruct()auto-detects Nassau when conditions are met (p=2, Milnor, finite-dimensional, no profile/cofiber) and a save directory is provided; without a save dir, standard is used to preserve in-memory quasi-inverse support#[cfg(feature = "nassau")]blocks removed from examples, utilities, and testsTest plan
make lintpassesmake testpasses (all lib, integration, doc, and pytest tests)make benchmarkspasses (output unchanged)cargo test --test milnor_vs_nassauconfirms nassau and standard produce identical output🤖 Generated with Claude Code