Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds macOS PKG installer build and signing capabilities to the build system. It introduces three new build targets for creating signed PKG installers, notarizing them with Apple, and generating unsigned DMG files.
Key Changes
- Added
create-pkgtarget that builds and signs a macOS PKG installer, including code signing of FlatLaf native libraries - Added
notarize-pkgtarget to submit PKG installers to Apple's notarization service - Updated icon file references to use a new directory structure and added version-suffixed icon copies for jpackage compatibility
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <arg line="--app-version ${dmg.version}"/> | ||
| <arg line="--vendor 'jdiskmark'"/> | ||
| <arg line="--dest ${dist.dir}"/> | ||
| <arg line="--resource-dir pkg/macos/images"/> |
There was a problem hiding this comment.
The resource directory path is hardcoded while other paths use properties. Consider defining this as a property for consistency and maintainability.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes