feat(overlay) use popover in overlay service #16835
Open
+105
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the overlay service by adopting the native Popover API to manage element layering, replacing the traditional z-index approach. The implementation adds the popover="manual" attribute to overlay wrapper elements and uses showPopover()/hidePopover() methods to control visibility in the browser's top layer.
Changes:
- Added Popover API integration with
showPopover()call before positioning andhidePopover()during cleanup - Removed z-index styling in favor of browser-managed top layer positioning
- Added comprehensive style overrides to reset browser default popover styles while maintaining custom overlay positioning
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| projects/igniteui-angular/core/src/services/overlay/overlay.ts | Implements Popover API calls in show/hide logic with proper error handling and browser compatibility checks |
| projects/igniteui-angular/core/src/core/styles/components/overlay/_overlay-theme.scss | Removes z-index properties and adds popover attribute styles to override browser defaults |
projects/igniteui-angular/core/src/core/styles/components/overlay/_overlay-theme.scss
Outdated
Show resolved
Hide resolved
dafo
added
💥 status: in-test
Hristo313
added
✅ status: verified
wnvko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
popoverglobal attribute to show the overlay. We are adding the attribute to overlay wrapper element and show the overlay by callingshowPopover.Closes #16824
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)