Open
Conversation
This was referenced Jan 29, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| baseUrl = started.baseUrl; | ||
| closeServer = started.close; | ||
|
|
||
| landscapeId = await resolveLandscapeId(baseUrl, TARGET_LANDSCAPE_NAME || ""); |
There was a problem hiding this comment.
TARGET_LANDSCAPE_ID is declared but never used
Medium Severity
The TARGET_LANDSCAPE_ID variable is read from the environment and checked in the guard clause (line 26), but resolveLandscapeId on line 37 only uses TARGET_LANDSCAPE_NAME, passing an empty string if it's undefined. If a user follows the README and provides only ICEPANEL_MCP_TEST_LANDSCAPE_ID, the test will fail because the ID is never passed to the resolver. Similarly, line 59 passes a potentially undefined TARGET_LANDSCAPE_NAME to normalizeNameForTest.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the docs and read tests to match the new read endpoints.
What I changed
Why I did it
Notes
Test plan
Note
Low Risk
Low risk: changes are limited to documentation and new integration tests; no server/runtime logic is modified.
Overview
Updates
README.mdwith a clearer Quick Start, stdio vs Streamable HTTP client configuration, a full reference list oficepanel_*read/write tools (including v0.3.0 naming/pagination), plus environment variables, CLI flags, Docker, and integration test setup.Adds
tests/read-tools.int.test.ts, an integration suite that conditionally runs with credentials and exercises the expanded read tool surface (tags/domains/connections/diagrams/flows, thumbnails, and CSV/JSON exports) against a real IcePanel org.Written by Cursor Bugbot for commit 05358b8. This will update automatically on new commits. Configure here.
Recommended merge order