T&A 47213: Correctly redirectes when pressing save and return on a question#11188
Open
matheuszych wants to merge 1 commit intoILIAS-eLearning:release_10from
Open
T&A 47213: Correctly redirectes when pressing save and return on a question#11188matheuszych wants to merge 1 commit intoILIAS-eLearning:release_10from
matheuszych wants to merge 1 commit intoILIAS-eLearning:release_10from
Conversation
Contributor
|
Hi @matheuszych I did not look at the content, but could you please take care to not remove the new lines. This has gotten harder to read. Best, |
matheuszych
force-pushed
the
ta/47213
branch
from
8dbc875 to
ea5a94d
Compare
Contributor
Author
|
Hello @kergomard , Best regards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://mantis.ilias.de/view.php?id=47213
Aims to correctly redirect the user when pressing save and return on a question.
While it may not be the most aesthetically pleasing solution, it is currently the only viable one, given the way the call order for this workflow is organized. Were we to directly call
$this->ctrl->redirect($gui, $cmd);, we would inadvertently trigger an endless redirection loop. To circumvent this predicament, we append a custom parameter to the URL, effectively marking the subsequent request as a redirect. As a result, any following request will not result in another redirect but will instead be relayed to the GUI class.@thojou