Api: Add event severity details on appeal api#2685
Draft
sudip-khanal wants to merge 2 commits intoproject/surge-eru-updatefrom
Draft
Api: Add event severity details on appeal api#2685sudip-khanal wants to merge 2 commits intoproject/surge-eru-updatefrom
sudip-khanal wants to merge 2 commits intoproject/surge-eru-updatefrom
Conversation
AdityaKhatri
requested changes
Mar 10, 2026
api/serializers.py
Outdated
| "name", | ||
| "ifrc_severity_level", | ||
| "ifrc_severity_level_display", | ||
| "disaster_start_date", |
Member
There was a problem hiding this comment.
Not sure if we need this.
We might need when severity level was changed.
api/serializers.py
Outdated
| country = MiniCountrySerializer(read_only=True) | ||
| dtype = DisasterTypeSerializer(read_only=True) | ||
| region = RegionSerializer(read_only=True) | ||
| event = EventMiniSerializer(source="appeal.event", read_only=True) |
Member
There was a problem hiding this comment.
Changing this might cause issues in the frontend where we are using event id from this. Double check with FE @shreeyash07 , if this causes any issues.
Member
There was a problem hiding this comment.
To be safe, we can rename this to event_details or something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
id,nameseverity levelon appeal apiChecklist
Things that should succeed before merging.
Release
If there is a version update, make sure to tag the repository with the latest version.