Eru: Add national society contribution on eru readiness api#2684
Draft
sudip-khanal wants to merge 3 commits intoproject/surge-eru-updatefrom
Draft
Eru: Add national society contribution on eru readiness api#2684sudip-khanal wants to merge 3 commits intoproject/surge-eru-updatefrom
sudip-khanal wants to merge 3 commits intoproject/surge-eru-updatefrom
Conversation
shreeyash07
requested changes
Mar 11, 2026
deployments/models.py
Outdated
| comment = models.TextField(verbose_name=_("comment"), blank=True, null=True) | ||
| ns_contribution = models.IntegerField( | ||
| choices=NationalSocietyContribution.choices, | ||
| verbose_name=_("National Souciety Contribution"), |
Contributor
There was a problem hiding this comment.
Suggested change
| verbose_name=_("National Souciety Contribution"), | |
| verbose_name=_("National Society Contribution"), |
susilnem
requested changes
Mar 11, 2026
| migrations.AddField( | ||
| model_name='erureadinesstype', | ||
| name='ns_contribution', | ||
| field=models.IntegerField(choices=[(1, 'Holds the ERU'), (2, 'Supports the ERU')], default=0, verbose_name='National Society Contribution'), |
Member
There was a problem hiding this comment.
What would be the value for the old data??
Contributor
Author
There was a problem hiding this comment.
I have added 0 as the default for now with preserve_default=False, @udaynwa is consulting with the client regarding the migration of existing data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Checklist
Things that should succeed before merging.
Release
If there is a version update, make sure to tag the repository with the latest version.