fix: forward browser user-agent in OpenRTB device.ua field#276
Open
ChristianPavilonis wants to merge 1 commit intomainfrom
Open
fix: forward browser user-agent in OpenRTB device.ua field#276ChristianPavilonis wants to merge 1 commit intomainfrom
device.ua field#276ChristianPavilonis wants to merge 1 commit intomainfrom
Conversation
aram356
requested changes
Feb 13, 2026
|
|
||
| /// Process gzip compressed input to uncompressed output (decompression only) | ||
| fn process_gzip_to_none<R: Read, W: Write>( | ||
| /// Decompress input, process content, and write uncompressed output. |
Collaborator
There was a problem hiding this comment.
❓ What are the changes to decompression? Please update summary
Collaborator
Author
There was a problem hiding this comment.
Updated, with refactor notes.
Probably should've been separate pr.
Collaborator
|
@jevansnyc Per https://www.iab.com/wp-content/uploads/2016/03/OpenRTB-API-Specification-Version-2-5-FINAL.pdf We need to think about passing some of the additional parameters. Can we document this in another ticket? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #264, #130
Summary
uafield to the OpenRTBDevicestruct so user-agent is serialized into bid requeststo_openrtbin the Prebid integration to mapDeviceInfo.user_agentintodevice.uaDeviceInfoconstruction to always include user-agent and IP, not just when geo lookup succeedsContext
Bidders like Kargo filter out requests with non-browser user-agents. Because
device.uawas never set, Prebid Server would fall back to the HTTP UA of the server-to-server call (e.g. the Fastly runtime), causing bidders to return 204 No Content on every request. Verified via isolated curl testing that UA is the sole deciding factor.Changes
crates/common/src/openrtb.rsua: Option<String>toDevicecrates/common/src/integrations/prebid.rsuser_agentintodevice.ua; use.map()instead of.and_then()so device is present even without geocrates/common/src/auction/formats.rsSome(DeviceInfo { .. })with geo as optional inside, instead of gating on geo lookupRefactoring
crates/common/src/streaming_processor.rsdecompress_and_processhelper to deduplicate identical decompress→process→write logic across gzip, deflate, and brotli*_to_nonemethodscrates/common/src/proxy.rsfinalize_responsehelper to consolidate repeatedstream_passthroughbranching (4 call sites)crates/common/src/integrations/prebid.rsvec![]→[]for staticcdn_patternsarraycrates/common/src/auction/formats.rsHashMapdirectly instead ofstd::collections::HashMap