Fixing the addition of multiple slashes to canonical URLs#170
Merged
grahamegrieve merged 3 commits intomainfrom Mar 14, 2026
Merged
Fixing the addition of multiple slashes to canonical URLs#170grahamegrieve merged 3 commits intomainfrom
grahamegrieve merged 3 commits intomainfrom
Conversation
…sure cacheKey and fingerprint are used for reliable retrieval and integrity.
… cache, fingerprint, and providers. All tests pass and coverage is 100%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds new unit tests for multiple modules related to OCL integration, background job queue, cache utilities, and concept map providers. It also removes two existing integration test files that used network mocking, likely to streamline or replace them with more focused unit tests. The main focus is on improving test coverage for core utilities and providers, and cleaning up older, more complex integration tests.
New unit tests added:
OCL Background Job Queue
OCLBackgroundJobQueuecovering job enqueuing, duplicate prevention, job size normalization, and heartbeat logging.Cache Utilities
formatCacheAgeMinutesincache-utils, with placeholders for additional cache utility tests.Concept Map Provider
OCLConceptMapProvider, including instantiation, ID assignment, and placeholders for further method and error flow tests.Removed integration tests:
Integration Tests Using Network Mocking
ocl-cm.test.js, which contained integration tests for concept map fetching, searching, translation, and caching usingnock.ocl-background-resilience.test.js, which tested background job queue resilience to various OCL API failures usingnock.