Skip to content

Update "models/parflow_pdaf" to v3.14.1-pdaf#123

Open
jjokella wants to merge 1 commit intomasterfrom
dev-update-parflow-pdaf
Open

Update "models/parflow_pdaf" to v3.14.1-pdaf#123
jjokella wants to merge 1 commit intomasterfrom
dev-update-parflow-pdaf

Conversation

@jjokella
Copy link
Contributor

Triggered by testing env/jsc.2026.gnu.openmpi (#122) for the TSMP-PDAF-testcases.

Compilation error for CLM3.5-ParFlow-PDAF

TSMP2_JUWELS_2026_03_20_master_ParFlow-CLM3.5-PDAF_RELEASE/models/parflow_pdaf/pfsimulator/parflow_lib/pf_hypre.c:78:59: error: incompatible type for argument 3 of ‘HYPRE_StructVectorSetValues’
   78 |       HYPRE_StructVectorSetValues(*hypre_b, index, rhs_ptr[iv]);
      |                                                    ~~~~~~~^~~~
      |                                                           |
      |                                                           double
TSMP2_JUWELS_2026_03_20_master_ParFlow-CLM3.5-PDAF_RELEASE/models/parflow_pdaf/pfsimulator/parflow_lib/loops.h:120:17: note: in definition of macro ‘BoxLoopI1_default’
  120 |                 body;                                                                   \
      |                 ^~~~
TSMP2_JUWELS_2026_03_20_master_ParFlow-CLM3.5-PDAF_RELEASE/models/parflow_pdaf/pfsimulator/parflow_lib/pf_hypre.c:71:5: note: in expansion of macro ‘BoxLoopI1’
   71 |     BoxLoopI1(i, j, k, ix, iy, iz, nx, ny, nz,
      |     ^~~~~~~~~
In file included from TSMP2_JUWELS_2026_03_20_master_ParFlow-CLM3.5-PDAF_RELEASE/models/parflow_pdaf/pfsimulator/parflow_lib/hypre_dependences.h:29,
                 from TSMP2_JUWELS_2026_03_20_master_ParFlow-CLM3.5-PDAF_RELEASE/models/parflow_pdaf/pfsimulator/parflow_lib/pf_hypre.c:36:
/p/software/default/stages/2026/software/Hypre/3.0.0-foss-2025b-cpu/include/HYPRE_struct_mv.h:553:49: note: expected ‘HYPRE_Complex *’ {aka ‘double *’} but argument is of type ‘double’
  553 |                             HYPRE_Complex      *values);
      |                             ~~~~~~~~~~~~~~~~~~~~^~~~~~
gmake[5]: *** [pfsimulator/parflow_lib/CMakeFiles/pfsimulator.dir/build.make:1268: pfsimulator/parflow_lib/CMakeFiles/pfsimulator.dir/pf_hypre.c.o] Error 1
gmake[5]: Leaving directory 'TSMP2_JUWELS_2026_03_20_master_ParFlow-CLM3.5-PDAF_RELEASE/bld/JUWELS_ParFlow-CLM3.5-PDAF/ParFlow/src/ParFlow-build'
gmake[4]: *** [CMakeFiles/Makefile2:1965: pfsimulator/parflow_lib/CMakeFiles/pfsimulator.dir/all] Error 2
gmake[4]: Leaving directory 'TSMP2_JUWELS_2026_03_20_master_ParFlow-CLM3.5-PDAF_RELEASE/bld/JUWELS_ParFlow-CLM3.5-PDAF/ParFlow/src/ParFlow-build'
gmake[3]: *** [Makefile:146: all] Error 2
gmake[3]: Leaving directory 'TSMP2_JUWELS_2026_03_20_master_ParFlow-CLM3.5-PDAF_RELEASE/bld/JUWELS_ParFlow-CLM3.5-PDAF/ParFlow/src/ParFlow-build'
gmake[2]: *** [CMakeFiles/ParFlow.dir/build.make:89: ParFlow/src/ParFlow-stamp/ParFlow-build] Error 2
gmake[2]: Leaving directory 'TSMP2_JUWELS_2026_03_20_master_ParFlow-CLM3.5-PDAF_RELEASE/bld/JUWELS_ParFlow-CLM3.5-PDAF'
gmake[1]: *** [CMakeFiles/Makefile2:169: CMakeFiles/ParFlow.dir/all] Error 2
gmake[1]: Leaving directory 'TSMP2_JUWELS_2026_03_20_master_ParFlow-CLM3.5-PDAF_RELEASE/bld/JUWELS_ParFlow-CLM3.5-PDAF'
gmake: *** [Makefile:94: all] Error 2

Current idea: I need to update the ParFlow-version.

@kvrigor , @AGonzalezNicolas Maybe you have seen this HYPRE error before?

Could this be related to #84 ?

@kvrigor
Copy link
Member

kvrigor commented Mar 20, 2026

@jjokella you need this fix in your parflow_pdaf repo: parflow/parflow@6f14cdb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants