Skip to content

fix[next-dace]: Add entry-point synchronization#2527

Open
edopao wants to merge 11 commits intoGridTools:mainfrom
edopao:dace_fix_sdfg_sync
Open

fix[next-dace]: Add entry-point synchronization#2527
edopao wants to merge 11 commits intoGridTools:mainfrom
edopao:dace_fix_sdfg_sync

Conversation

@edopao
Copy link
Contributor

@edopao edopao commented Mar 12, 2026 •
edited
Loading

This PR contains two changes:

  1. The main one is to add a synchronization point before retrieving the start timestamp:
cudaDeviceSynchronize()
start = chrono::now()
...
cudaDeviceSynchronize()
stop = chrono::now()
  1. Fix setting of SDFG start block: invalidate the cached start block when inserting a new start block for time measurement.

philip-paul-mueller
philip-paul-mueller reviewed Mar 19, 2026
View reviewed changes
Copy link
Contributor

@philip-paul-mueller philip-paul-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have some small suggestions.

@edopao edopao force-pushed the dace_fix_sdfg_sync branch 2 times, most recently from 93573b7 to 3e8887c Compare March 23, 2026 09:16
@edopao edopao force-pushed the dace_fix_sdfg_sync branch from 3e8887c to cb89e7a Compare March 23, 2026 09:58
philip-paul-mueller
philip-paul-mueller reviewed Mar 23, 2026
View reviewed changes
Copy link
Contributor

@philip-paul-mueller philip-paul-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The start state of the SDFG is not updated correctly as far as I can tell.

philip-paul-mueller
philip-paul-mueller approved these changes Mar 23, 2026
View reviewed changes
Copy link
Contributor

@philip-paul-mueller philip-paul-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions, but nothing big.

@edopao edopao force-pushed the dace_fix_sdfg_sync branch from 6af5fda to dd19dbb Compare March 23, 2026 14:54
@edopao
Copy link
Contributor Author

edopao commented Mar 23, 2026

I have reverted the changes to make_sdfg_call_sync(), because there was no real need. This PR still contains two important changes, as explained in the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philip-paul-mueller philip-paul-mueller Awaiting requested review from philip-paul-mueller

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edopao @philip-paul-mueller