Open
Conversation
gustovafing
added
type: refactor
github-actions
bot
added
Tests: Passed
github-actions
bot
added
Tests: Failed
github-actions
bot
added
Tests: Passed
YoungOnionMC
requested changes
Feb 17, 2026
|
|
||
| @MethodsReturnNonnullByDefault | ||
| @ParametersAreNonnullByDefault | ||
| public abstract class GTFluidImpl extends GTFluid implements IForgeFluid { |
Member
There was a problem hiding this comment.
how come this was deleted, dont we still use it for our fluids?
Member
There was a problem hiding this comment.
oh, yea the 1.21 fluid migration should go into a separate PR
| import com.gregtechceu.gtceu.common.entity.GTBoat; | ||
| import com.gregtechceu.gtceu.common.item.*; | ||
| import com.gregtechceu.gtceu.common.item.armor.*; | ||
| import com.gregtechceu.gtceu.common.item.behavior.*; |
Member
There was a problem hiding this comment.
we dont need the other 2 imports if we import everything in the package :bz_reading:
|
|
||
| import java.util.Locale; | ||
|
|
||
| public class TagFixer { |
Member
There was a problem hiding this comment.
how come this was deleted?
Member
Author
There was a problem hiding this comment.
never used, plus the fix is does is for an ancient gt version and doesn't even do anything anymore
| import lombok.experimental.Accessors; | ||
|
|
||
| @Accessors(fluent = true) | ||
| public class CableData implements IAttachData { |
Member
There was a problem hiding this comment.
how come this was deleted?
| } | ||
|
|
||
| @SubscribeEvent | ||
| public static void addAlloyBlastProperties(PostMaterialEvent event) { |
Member
There was a problem hiding this comment.
maybe? moving the alloy blast event back to common event listener should be its own pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
forge/folder, rename Forge(Client/Common)EventListener to (Client/Common)EventListenerGTCapabilityfile fromapi/capability/forgetoapi/capabilityforge/folders to be in their parent folders where there is no difference in api between forge/neoforge