Skip to content

Add textures referenced by used meshes to packfile from level editor#347

Open
GooberRF wants to merge 5 commits intomasterfrom
meshtex
Open

Add textures referenced by used meshes to packfile from level editor#347
GooberRF wants to merge 5 commits intomasterfrom
meshtex

Conversation

@GooberRF
Copy link
Copy Markdown
Owner

@GooberRF GooberRF commented Apr 7, 2026

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the level editor’s VPP packfile generation to also include textures referenced by custom meshes used in a level, preventing missing-material issues when distributing user maps that rely on loose .v3m/.v3c files.

Changes:

  • Add disk lookup and V3M/V3C parsing helpers to extract diffuse texture references from mesh files.
  • Extend VPP packing to add textures referenced by DedMesh objects and Switch_Model events.
  • Centralize V3D/V3M constants/types in meshes.h and update mesh export code to use them.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
editor_patch/textures.cpp Adds mesh-texture extraction to the VPP texture-gathering step and reuses mesh disk lookup.
editor_patch/meshes.h Introduces shared V3D structs/constants and declares mesh lookup + texture extraction APIs.
editor_patch/meshes.cpp Implements find_mesh_on_disk() and extract_v3d_texture_names() (binary parser).
editor_patch/mesh_export.cpp Replaces duplicated V3D constants with the shared definitions from meshes.h.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GooberRF GooberRF marked this pull request as ready for review April 7, 2026 18:52
@GooberRF GooberRF requested a review from Copilot April 7, 2026 18:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants