Conversation
# Conflicts: # game_patch/multi/network.cpp
There was a problem hiding this comment.
Pull request overview
Updates Alpine Faction’s join_accept packet extension to be more forward-compatible and safer to parse by introducing a footer-based tail format for newer clients while retaining legacy compatibility.
Changes:
- Added patch/type version bytes and explicit packing/size assertion for
AlpineFactionJoinAcceptPacketExt. - Send footer-based AF tail for AF 1.3+ clients; keep legacy raw-append for older clients.
- Added a shared parser that can detect and parse either footer-based or legacy
join_acceptextensions; extendedAlpineFactionServerInfowith patch/type fields.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
game_patch/multi/network.h |
Extends and hardens the on-wire join_accept AF extension struct (packing, version fields, defaults, size assert). |
game_patch/multi/network.cpp |
Switches send format based on client version and adds dual-format parsing logic for received join_accept. |
game_patch/multi/multi.h |
Stores additional AF server version info (patch/type) parsed from join_accept. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.