Skip to content

Added fix(recorder): replace colons in filenames to ensure Windows compatibilty and runs across other platforms as well #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Res260 merged 3 commits into from
Jul 27, 2025
Merged

Added fix(recorder): replace colons in filenames to ensure Windows compatibilty and runs across other platforms as well #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53afb77
Added fix(recorder): replace colons in filenames to ensure Windows co…
Cap-Levi Jul 26, 2025
2f11142
Fixed the integration.sh by changing the hardcoded filenames.
Cap-Levi Jul 27, 2025
9f4a2ee
sanitize sessionID by replacing colons in filenames
Cap-Levi Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyrdp/convert/PCAPConverter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ def processStream(self, startTimeStamp: int, stream: PCAPStream):
"src": stream.client,
"dst": stream.server
})
sessionID = sessionID.replace(":", "_")

handler, _ = createHandler(self.format, self.outputPrefix + sessionID)
replayer = RDPReplayer(handler, self.outputPrefix, sessionID)
Expand Down
2 changes: 2 additions & 0 deletions pyrdp/recording/recorder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ def __init__(self, fileName: Union[str, Path]):
self.pending = b''

self.filename = fileName
self.filename = str(self.filename).replace(":", "_")

self.fd: BufferedIOBase = None

def sendBytes(self, data: bytes):
Expand Down
8 changes: 4 additions & 4 deletions test/integration.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ echo

echo ===================================================
echo Verify the PCAP to JSON file
./test/validate_json.sh "20200319000716_192.168.38.1:20989-192.168.38.1:3389.json"
rm "20200319000716_192.168.38.1:20989-192.168.38.1:3389.json"
./test/validate_json.sh "20200319000716_192.168.38.1_20989-192.168.38.1_3389.json"
rm "20200319000716_192.168.38.1_20989-192.168.38.1_3389.json"
echo

echo ===================================================
Expand All @@ -75,8 +75,8 @@ echo

echo ===================================================
echo Verify that the replay file exists
file -E "20200319000716_192.168.38.1:20989-192.168.38.1:3389.pyrdp"
rm "20200319000716_192.168.38.1:20989-192.168.38.1:3389.pyrdp"
file -E "20200319000716_192.168.38.1_20989-192.168.38.1_3389.pyrdp"
rm "20200319000716_192.168.38.1_20989-192.168.38.1_3389.pyrdp"

echo ===================================================
echo pyrdp-convert.py regression issue 428
Expand Down
Loading