Add missing permissions message in Video SDK#1638
Merged
aleksandar-apostolov merged 1 commit intodevelopfrom Apr 1, 2026
Merged
Conversation
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
WalkthroughThese changes enhance error handling for denied call permissions by explicitly computing missing permissions and reporting them via the error callback instead of silently returning without notification. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ❌ 3❌ Failed checks (3 warnings)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
stream-video-android-ui-core/src/main/kotlin/io/getstream/video/android/ui/common/StreamCallActivity.kt (1)
889-902: Improve missing-permission message readability and empty-list fallback.At Line 894-900, the current message is built from raw manifest constants, which produces low-readability text. It’s better to format user-facing permission labels and guarantee a non-empty fallback message.
💡 Proposed refinement
if (!permissionsNowGranted) { val missingPermissions = PermissionManager.getMissingPermission( this@StreamCallActivity, call, ) - val exceptionText = - missingPermissions.map { it.capitalize(Locale.getDefault()) } - .joinToString(separator = ",") { it } + val exceptionText = missingPermissions + .map { permission -> + permission.substringAfterLast('.') + .replace('_', ' ') + .lowercase(Locale.getDefault()) + .replaceFirstChar { firstChar -> + firstChar.titlecase(Locale.getDefault()) + } + } + .ifEmpty { listOf("Required permission") } + .joinToString(separator = ", ") onError?.invoke( StreamCallActivityException( call, - "$exceptionText Permission(s) not granted.", + "$exceptionText not granted.", null, ), ) return@launch }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@stream-video-android-ui-core/src/main/kotlin/io/getstream/video/android/ui/common/StreamCallActivity.kt` around lines 889 - 902, The missing-permission message is built from raw manifest constants; update the logic around PermissionManager.getMissingPermission in StreamCallActivity (where StreamCallActivityException is created) to map each permission constant to a human-friendly label (e.g., "Camera", "Microphone", "Storage"), capitalize with Locale.getDefault(), join with ", " for readability, and if the missingPermissions list is empty produce a clear fallback string like "Required permissions not granted" before constructing the StreamCallActivityException so the user-facing message is always readable and non-empty.stream-video-android-ui-core/src/main/kotlin/io/getstream/video/android/ui/common/permission/PermissionManager.kt (1)
131-150: Consider centralizing capability→permission mapping to avoid drift.Line 135-148 duplicates the permission checks already present in Line 114-127. Extracting a shared helper for required/missing permissions would keep behavior aligned and reduce future regression risk.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@stream-video-android-ui-core/src/main/kotlin/io/getstream/video/android/ui/common/permission/PermissionManager.kt` around lines 131 - 150, The duplicate capability→permission logic should be centralized: create a single helper (e.g., requiredPermissionsForCapabilities or a PERMISSION_MAP) that maps OwnCapability values (OwnCapability.SendAudio, OwnCapability.SendVideo) to Android permission strings (Manifest.permission.RECORD_AUDIO, Manifest.permission.CAMERA) and use it from getMissingPermission and the earlier permission-check block; then implement getMissingPermission to iterate the required permissions for call.state.ownCapabilities.value and add any not granted (via ContextCompat.checkSelfPermission) to the returned list so both places share the same source of truth.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@stream-video-android-ui-core/src/main/kotlin/io/getstream/video/android/ui/common/permission/PermissionManager.kt`:
- Around line 131-150: The duplicate capability→permission logic should be
centralized: create a single helper (e.g., requiredPermissionsForCapabilities or
a PERMISSION_MAP) that maps OwnCapability values (OwnCapability.SendAudio,
OwnCapability.SendVideo) to Android permission strings
(Manifest.permission.RECORD_AUDIO, Manifest.permission.CAMERA) and use it from
getMissingPermission and the earlier permission-check block; then implement
getMissingPermission to iterate the required permissions for
call.state.ownCapabilities.value and add any not granted (via
ContextCompat.checkSelfPermission) to the returned list so both places share the
same source of truth.
In
`@stream-video-android-ui-core/src/main/kotlin/io/getstream/video/android/ui/common/StreamCallActivity.kt`:
- Around line 889-902: The missing-permission message is built from raw manifest
constants; update the logic around PermissionManager.getMissingPermission in
StreamCallActivity (where StreamCallActivityException is created) to map each
permission constant to a human-friendly label (e.g., "Camera", "Microphone",
"Storage"), capitalize with Locale.getDefault(), join with ", " for readability,
and if the missingPermissions list is empty produce a clear fallback string like
"Required permissions not granted" before constructing the
StreamCallActivityException so the user-facing message is always readable and
non-empty.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 93c1acdf-27ce-4b8d-9dcc-dc465f814f8c
📒 Files selected for processing (2)
stream-video-android-ui-core/src/main/kotlin/io/getstream/video/android/ui/common/StreamCallActivity.ktstream-video-android-ui-core/src/main/kotlin/io/getstream/video/android/ui/common/permission/PermissionManager.kt
|
aleksandar-apostolov
changed the title
aleksandar-apostolov
approved these changes
Apr 1, 2026
aleksandar-apostolov
changed the title
CallService
aleksandar-apostolov
deleted the
chore/rahullohra/ougoing-call-fg-service-remaining-commit
branch
rahul-lohra
changed the title
CallService
Collaborator
|
🚀 Available in v1.21.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Add Missing commit for #1627
Implementation
Add missing permission message
🎨 UI Changes
Refer #1627
Testing
Refer #1627
Summary by CodeRabbit