Skip to content

pstext -D[j|J] is broken#8940

Open
Chuan1937 wants to merge 12 commits intomasterfrom
fix
Open

pstext -D[j|J] is broken#8940
Chuan1937 wants to merge 12 commits intomasterfrom
fix

Conversation

@Chuan1937
Copy link
Member

Replace #8921

@Chuan1937 Chuan1937 self-assigned this Mar 21, 2026
@Chuan1937 Chuan1937 added the bug Something isn't working label Mar 21, 2026
@Chuan1937 Chuan1937 added this to the 6.7.0 milestone Mar 21, 2026
@joa-quim
Copy link
Member

I have made some attempts to fix this with the help of Claude and results don't differ much from yours. I'm getting irritated with this that is consuming so much effort for nothing. Honestly, I don't even see the interest of -Dj|J, special since 'j' seems to be the default and 'J' I don't even see what it is good for. So, I changed strategy and cheat it on the source of the trouble. If it works fine with -D5c and not with Dj5c, just drop the 'j' in the parsing stage. This won't fix the non working -DJ but maybe we should just drop from the docs. Anyway, I've just had enough of this.

Changing pstext.c line 189 to

if (Ctrl->D.justify && !(Ctrl->D.justify == 1 && T->block_justify == PSL_MC)) /* Smart offset according to justification (from Dave Huang) */

fixes the issue, so please be my guest and apply this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants