Skip to content

#5040 Remove duplicate timeout setting#6187

Merged
sosnovsky merged 3 commits intomasterfrom
5040-remove-duplicate-timeout-setting
Mar 17, 2026
Merged

#5040 Remove duplicate timeout setting#6187
sosnovsky merged 3 commits intomasterfrom
5040-remove-duplicate-timeout-setting

Conversation

@ioanatflowcrypt
Copy link
Collaborator

This PR removed duplicate timeout setting

close #5040 // if this PR closes an issue


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanatflowcrypt
Copy link
Collaborator Author

Tried removing --timeout from AVA scripts to reduce duplicate timeout settings, but it's actually needed.

Without it, AVA uses a default timeout which is too short — our browser tests often wait minutes for a pool slot, so AVA thinks nothing is happening and kills the run:

get.key@key-manager-autogen.flowcrypt.test (5m 4.7s)
✘ Timed out while running tests
311 tests were pending

The three timeout layers each cover different things:

  • --timeout (AVA) — progress watchdog, resets after each test finishes
  • TIMEOUT_EACH_RETRY / TIMEOUT_ALL_RETRIES (in-code) — per-test and per-test-with-retries limits
  • execution_time_limit (Semaphore) — hard kill on the CI job

Removed TIMEOUT_OVERALL instead — it was 60min, always racing against TIMEOUT_ALL_RETRIES at 55min in the same Promise.race, so it could never win.

@ioanatflowcrypt ioanatflowcrypt marked this pull request as ready for review March 17, 2026 00:41
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@sosnovsky sosnovsky merged commit 8170466 into master Mar 17, 2026
12 checks passed
@sosnovsky sosnovsky deleted the 5040-remove-duplicate-timeout-setting branch March 17, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove duplicate timeout setting

2 participants