Skip to content

fix bug in creating test images and change success criterion for tests. #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kriboe90 merged 1 commit into from
Feb 23, 2026
Merged

fix bug in creating test images and change success criterion for tests. #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ledsa/tests/AcceptanceTests/05_test_analysis.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,4 @@ Check Results

Rmse Should Be Small
[Arguments] ${rmse}
Should Be True ${rmse} < 0.15
Should Be True ${rmse} < 0.05
3 changes: 1 addition & 2 deletions ledsa/tests/AcceptanceTests/LedsaATestLibrary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,6 @@ def create_test_image(image_id, experiment):
num_of_leds = len(experiment.leds)
transmissions = experiment.calc_all_led_transmissions()
img_array = create_img_array(num_of_leds, transmissions)
img_array = np.clip(img_array, 0, 255).astype(np.uint8)
img = Image.fromarray(img_array, 'RGB')

# Save image without EXIF data
Expand All @@ -190,7 +189,7 @@ def create_test_image(image_id, experiment):


def create_img_array(num_of_leds, transmissions):
img = np.zeros((num_of_leds * 50 + 50, 50, 3), np.int8)
img = np.zeros((num_of_leds * 50 + 50, 50, 3), np.uint8)
for led_id in range(num_of_leds):
add_led(img, (1 + led_id) * 50, 25, transmissions[led_id])
return img
Expand Down
Loading