Skip to content

don't bring out the heavy json parse just to check a string #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seifertk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

don't bring out the heavy json parse just to check a string #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/flow-spec/IBlock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,14 @@ export function createEvalContactFrom(contact: IContact): IContact {
}

export function evaluateToBool(expr: string, ctx: object): boolean {
return JSON.parse(evaluateToString(expr, ctx).toLowerCase())
const result = evaluateToString(expr, ctx).toLowerCase().trim()
Copy link
Collaborator

@AlteaDown AlteaDown Jul 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a measurable performance impact in making this change, and if so, what is that measurement?

if (result === 'true') {
return true
}
if (result === 'false') {
return false
}
throw new ValidationException(`Expression "${expr} does not evaluate to bool: ${result}"`)
}

export function evaluateToString(expr: string, ctx: object): string {
Expand Down