VMO-3852 Support deep linking for simulator + VMO-3687 Simulator on read only view by poojahpatil90 · Pull Request #75 · FLOIP/flow-builder

poojahpatil90 · 2021-04-27T04:47:08Z

…ator # Conflicts: # builder.config.json # src/components/interaction-designer/toolbar/TreeBuilderToolbar.vue # src/store/flow/block-types/MobilePrimitives_SelectManyResponseBlockStore.ts # src/views/InteractionDesigner.vue # tests/unit/__snapshots__/storybook.spec.ts.snap

…-simulator # Conflicts: # src/components/interaction-designer/toolbar/TreeBuilderToolbar.vue # src/store/clipboard/index.ts # src/views/InteractionDesigner.vue # tests/unit/__snapshots__/storybook.spec.ts.snap

safydy-r · 2021-06-16T20:16:17Z

src/components/interaction-designer/toolbar/TreeBuilderToolbar.vue

-      })
+    return {
+      params: {
+        id: this.activeFlow?.uuid,


Wouldn't this be treeId: this.activeFlow?.uuid ?

And I'm a bit confused why we removed component: ?

@safydy-r Good question! There are two ways to use routes:

Use route.from({component: 'interaction-designer', mode: 'view', treeId: this.activeFlow?.uuid}) from routes.js mixin. Example: See here

Use Vue router's route name and pass the parameters as defined in the route config. Example: See here
Here the route is already setup beforehand and when we are click on Edit/View Flow button in the toolbar, I am just passing in the new mode along with flowId(just to be sure). I feel it is much simpler to use routes this way rather than having a dependency on builder.config and routes mixin.
Thoughts?

@poojahpatil90
Sorry, I still don't understand, hihi 😸 . But it seems you know what you are doing here. I just love to have a quick call to understand why we still providing mode: this.isEditable ? 'view' : 'edit' here and not component: 'interaction-designer',.

safydy-r · 2021-06-16T20:34:59Z

src/views/InteractionDesigner.vue

      if (field) {
        scrollBehavior(this.$route)
      }
+      if (this.$route.name === 'flow-simulator' && this.hasSimulator()) {


As we already have this condition here, what if we change <div v-if="$route.name === 'flow-simulator' && hasSimulator" class="tree-sidebar"> from this line
https://github.com/FLOIP/flow-builder/blob/VMO-3852-deep-linking-simulator/src/views/InteractionDesigner.vue#L21 with <div v-if="isSimulatorActive" class="tree-sidebar">

Would that work?

@safydy-r This condition has been added here to open up the simulator when the URL says /simulator. This is needed here specifically to handle UI refresh and the URL being pasted in a new tab/window of the browser.
In order to use isSimulatorActive, it needs to be set true already. but as you can see I am setting it below after catching the simulator URL.
I agree comparing the route name isn't ideal, but I cannot think of any better solution. Let me know your thoughts?

src/components/interaction-designer/toolbar/TreeBuilderToolbar.vue

safydy-r

Overall I'm ok, but left few questions for you @poojahpatil90

# Resolved Conflicts: # src/components/interaction-designer/toolbar/TreeBuilderToolbar.vue # src/views/InteractionDesigner.vue # tests/unit/__snapshots__/storybook.spec.ts.snap

github-actions · 2021-06-29T00:00:39Z

src/router/trees.js

+      {
+        path: 'simulator',
+        name: 'flow-simulator',
+        meta: { isSidebarShown: true },


Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/router/trees.js L38

There should be no space after '{'. (object-curly-spacing)

github-actions · 2021-06-29T00:00:39Z

src/router/trees.js

+      {
+        path: 'simulator',
+        name: 'flow-simulator',
+        meta: { isSidebarShown: true },


Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/router/trees.js L38

There should be no space before '}'. (object-curly-spacing)

github-actions · 2021-06-29T00:00:40Z

src/store/clipboard/index.ts

@@ -58,7 +64,7 @@ export const actions: ActionTree<IClipboardState, IRootState> = {
  },
  removeFromBlocksData({ state }, index: number) {


Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L65

There should be no space after '{'. (object-curly-spacing)

github-actions · 2021-06-29T00:00:41Z

src/store/clipboard/index.ts

@@ -58,7 +64,7 @@ export const actions: ActionTree<IClipboardState, IRootState> = {
  },
  removeFromBlocksData({ state }, index: number) {


Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L65

There should be no space before '}'. (object-curly-spacing)

github-actions · 2021-06-29T00:00:41Z

src/store/clipboard/index.ts

+      name: routeName,
+    })
  },
  resetBlocksData({ state }) {


Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L48

There should be no space after '{'. (object-curly-spacing)

github-actions · 2021-06-29T00:00:42Z

src/store/clipboard/index.ts

+      name: routeName,
+    })
  },
  resetBlocksData({ state }) {


Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L48

There should be no space before '}'. (object-curly-spacing)

github-actions · 2021-06-29T00:00:43Z

src/store/clipboard/index.ts

 export const actions: ActionTree<IClipboardState, IRootState> = {
  setSimulatorActive({ commit }, value) {
    commit('setSimulatorActive', value)
+    const routeName = value ? 'flow-simulator' : 'flow-details'


Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/strict-boolean-expressions
Severity: ERROR
File: src/store/clipboard/index.ts L43

Unexpected any value in conditional. An explicit comparison or type cast is required. (@typescript-eslint/strict-boolean-expressions)

github-actions · 2021-06-29T00:00:44Z

src/store/clipboard/index.ts

@@ -38,6 +40,10 @@ export const mutations: MutationTree<IClipboardState> = {
 export const actions: ActionTree<IClipboardState, IRootState> = {
  setSimulatorActive({ commit }, value) {


Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L41

There should be no space after '{'. (object-curly-spacing)

github-actions · 2021-06-29T00:00:44Z

src/store/clipboard/index.ts

@@ -38,6 +40,10 @@ export const mutations: MutationTree<IClipboardState> = {
 export const actions: ActionTree<IClipboardState, IRootState> = {
  setSimulatorActive({ commit }, value) {


Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L41

There should be no space before '}'. (object-curly-spacing)

github-actions · 2021-06-29T00:00:45Z

src/store/clipboard/index.ts

  blocksData: (state) => state.blocksData,
  getBlockPrompt: (state) => (index: number) => state.blocksData[index].prompt,
  isBlockFocused: (state) => (index: number) => state.blocksData[index].isFocused,
+  hasSimulator: (_, _2, _3, rootGetters) => rootGetters['flow/hasOfflineMode'] && rootGetters.isFeatureSimulatorEnabled && !rootGetters['builder/isEditable'],


Reporter: ESLint
Rule: eslint.rules.max-len
Severity: WARN
File: src/store/clipboard/index.ts L28

This line has a length of 158. Maximum allowed is 140. (max-len)

github-actions · 2021-06-29T00:00:46Z

src/store/clipboard/index.ts

  blocksData: (state) => state.blocksData,
  getBlockPrompt: (state) => (index: number) => state.blocksData[index].prompt,
  isBlockFocused: (state) => (index: number) => state.blocksData[index].isFocused,
+  hasSimulator: (_, _2, _3, rootGetters) => rootGetters['flow/hasOfflineMode'] && rootGetters.isFeatureSimulatorEnabled && !rootGetters['builder/isEditable'],


Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/strict-boolean-expressions
Severity: ERROR
File: src/store/clipboard/index.ts L28

Unexpected any value in conditional. An explicit comparison or type cast is required. (@typescript-eslint/strict-boolean-expressions)

github-actions · 2021-06-29T00:00:46Z

src/store/clipboard/index.ts

  blocksData: (state) => state.blocksData,
  getBlockPrompt: (state) => (index: number) => state.blocksData[index].prompt,
  isBlockFocused: (state) => (index: number) => state.blocksData[index].isFocused,
+  hasSimulator: (_, _2, _3, rootGetters) => rootGetters['flow/hasOfflineMode'] && rootGetters.isFeatureSimulatorEnabled && !rootGetters['builder/isEditable'],


Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/strict-boolean-expressions
Severity: ERROR
File: src/store/clipboard/index.ts L28

Unexpected any value in conditional. An explicit comparison or type cast is required. (@typescript-eslint/strict-boolean-expressions)

github-actions · 2021-06-29T00:00:47Z

src/store/clipboard/index.ts

+import { IPrompt } from '@floip/flow-runner'

 export interface BlocksData {
  isFocused: boolean;


Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/member-delimiter-style
Severity: WARN
File: src/store/clipboard/index.ts L9

Expected a comma. (@typescript-eslint/member-delimiter-style)

github-actions · 2021-06-29T00:00:47Z

src/store/clipboard/index.ts

 import { IRootState } from '@/store'
-import { IPrompt } from '@floip/flow-runner';
+import { router } from '@/router'
+import { IPrompt } from '@floip/flow-runner'


Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L6

There should be no space after '{'. (object-curly-spacing)

github-actions · 2021-06-29T00:00:48Z

src/store/clipboard/index.ts

 import { IRootState } from '@/store'
-import { IPrompt } from '@floip/flow-runner';
+import { router } from '@/router'
+import { IPrompt } from '@floip/flow-runner'


Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L6

There should be no space before '}'. (object-curly-spacing)

github-actions · 2021-06-29T00:00:49Z

src/store/clipboard/index.ts

 } from 'vuex'
 import { IRootState } from '@/store'
-import { IPrompt } from '@floip/flow-runner';
+import { router } from '@/router'


Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L5

There should be no space after '{'. (object-curly-spacing)

github-actions · 2021-06-29T00:00:49Z

src/store/clipboard/index.ts

 } from 'vuex'
 import { IRootState } from '@/store'
-import { IPrompt } from '@floip/flow-runner';
+import { router } from '@/router'


Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L5

There should be no space before '}'. (object-curly-spacing)

github-actions · 2021-06-29T00:00:50Z

src/store/clipboard/index.ts

@@ -2,7 +2,8 @@ import {
  ActionTree, GetterTree, Module, MutationTree,
 } from 'vuex'
 import { IRootState } from '@/store'


Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L4

There should be no space after '{'. (object-curly-spacing)

github-actions · 2021-06-29T00:00:51Z

src/store/clipboard/index.ts

@@ -2,7 +2,8 @@ import {
  ActionTree, GetterTree, Module, MutationTree,
 } from 'vuex'
 import { IRootState } from '@/store'


Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L4

There should be no space before '}'. (object-curly-spacing)

# Resolved Conflicts: # src/components/interaction-designer/toolbar/TreeBuilderToolbar.vue # src/views/InteractionDesigner.vue # tests/unit/__snapshots__/storybook.spec.ts.snap

github-actions · 2021-08-13T03:54:49Z

src/components/interaction-designer/toolbar/TreeBuilderToolbar.vue

@@ -496,12 +495,7 @@ export default class TreeBuilderToolbar extends mixins(Routes, Permissions, Lang
    return (this.can('view-result-totals') && this.isFeatureViewResultsEnabled)


Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/strict-boolean-expressions
Severity: ERROR
File: src/components/interaction-designer/toolbar/TreeBuilderToolbar.vue L495

Unexpected any value in conditional. An explicit comparison or type cast is required. (@typescript-eslint/strict-boolean-expressions)

# Resolved Conflicts: # src/views/InteractionDesigner.vue

github-actions · 2021-08-24T18:12:39Z

Found 24 violations:

Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/strict-boolean-expressions
Severity: ERROR
File: src/components/interaction-designer/toolbar/TreeBuilderToolbar.vue L495

Unexpected any value in conditional. An explicit comparison or type cast is required. (@typescript-eslint/strict-boolean-expressions)

Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/router/trees.js L38

There should be no space after '{'. (object-curly-spacing)

Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/router/trees.js L38

There should be no space before '}'. (object-curly-spacing)

Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L65

There should be no space after '{'. (object-curly-spacing)

Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L65

There should be no space before '}'. (object-curly-spacing)

Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L48

There should be no space after '{'. (object-curly-spacing)

Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L48

There should be no space before '}'. (object-curly-spacing)

Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/strict-boolean-expressions
Severity: ERROR
File: src/store/clipboard/index.ts L43

Unexpected any value in conditional. An explicit comparison or type cast is required. (@typescript-eslint/strict-boolean-expressions)

Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L41

There should be no space after '{'. (object-curly-spacing)

Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L41

There should be no space before '}'. (object-curly-spacing)

Reporter: ESLint
Rule: eslint.rules.max-len
Severity: WARN
File: src/store/clipboard/index.ts L28

This line has a length of 158. Maximum allowed is 140. (max-len)

Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/strict-boolean-expressions
Severity: ERROR
File: src/store/clipboard/index.ts L28

Unexpected any value in conditional. An explicit comparison or type cast is required. (@typescript-eslint/strict-boolean-expressions)

Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/strict-boolean-expressions
Severity: ERROR
File: src/store/clipboard/index.ts L28

Unexpected any value in conditional. An explicit comparison or type cast is required. (@typescript-eslint/strict-boolean-expressions)

Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/member-delimiter-style
Severity: WARN
File: src/store/clipboard/index.ts L9

Expected a comma. (@typescript-eslint/member-delimiter-style)

Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L6

There should be no space after '{'. (object-curly-spacing)

Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L6

There should be no space before '}'. (object-curly-spacing)

Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L5

There should be no space after '{'. (object-curly-spacing)

Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L5

There should be no space before '}'. (object-curly-spacing)

Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L4

There should be no space after '{'. (object-curly-spacing)

Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/store/clipboard/index.ts L4

There should be no space before '}'. (object-curly-spacing)

Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/strict-boolean-expressions
Severity: ERROR
File: src/views/InteractionDesigner.vue L209

Unexpected any value in conditional. An explicit comparison or type cast is required. (@typescript-eslint/strict-boolean-expressions)

Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/strict-boolean-expressions
Severity: ERROR
File: src/views/InteractionDesigner.vue L206

Unexpected any value in conditional. An explicit comparison or type cast is required. (@typescript-eslint/strict-boolean-expressions)

Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/explicit-module-boundary-types
Severity: WARN
File: src/views/InteractionDesigner.vue L138

Missing return type on function. (@typescript-eslint/explicit-module-boundary-types)

Reporter: ESLint
Rule: eslint.rules.vue/max-attributes-per-line
Severity: WARN
File: src/views/InteractionDesigner.vue L14

'class' should be on a new line. (vue/max-attributes-per-line)

github-actions · 2021-08-24T18:12:44Z

src/views/InteractionDesigner.vue

      if (this.$route.meta?.isBlockEditorShown) {
        this.setIsBlockEditorOpen(true)
      }
+      if (this.$route.name === 'flow-simulator' && this.hasSimulator()) {


Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/strict-boolean-expressions
Severity: ERROR
File: src/views/InteractionDesigner.vue L209

Unexpected any value in conditional. An explicit comparison or type cast is required. (@typescript-eslint/strict-boolean-expressions)

github-actions · 2021-08-24T18:12:45Z

src/views/InteractionDesigner.vue

@@ -221,6 +206,9 @@ export default {
      if (this.$route.meta?.isBlockEditorShown) {


Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/strict-boolean-expressions
Severity: ERROR
File: src/views/InteractionDesigner.vue L206

Unexpected any value in conditional. An explicit comparison or type cast is required. (@typescript-eslint/strict-boolean-expressions)

github-actions · 2021-08-24T18:12:45Z

src/views/InteractionDesigner.vue

-    ...mapGetters('clipboard', ['isSimulatorActive']),
+    ...mapGetters('clipboard', ['hasSimulator', 'isSimulatorActive']),

    jsKey() {


Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/explicit-module-boundary-types
Severity: WARN
File: src/views/InteractionDesigner.vue L138

Missing return type on function. (@typescript-eslint/explicit-module-boundary-types)

github-actions · 2021-08-24T18:12:46Z

src/views/InteractionDesigner.vue

-
-      <div
-        class="tree-sidebar">
+      <div v-if="$route.name === 'flow-simulator' && hasSimulator" class="tree-sidebar">


Reporter: ESLint
Rule: eslint.rules.vue/max-attributes-per-line
Severity: WARN
File: src/views/InteractionDesigner.vue L14

'class' should be on a new line. (vue/max-attributes-per-line)

safydy-r

Sorry for the late review here @poojahpatil90 , I'm approving.
I'd like to catchup with you about my question on route params later.
Thanks

safydy-r · 2021-08-25T00:07:46Z

src/components/interaction-designer/toolbar/TreeBuilderToolbar.vue

-      })
+    return {
+      params: {
+        id: this.activeFlow?.uuid,


@poojahpatil90
Sorry, I still don't understand, hihi 😸 . But it seems you know what you are doing here. I just love to have a quick call to understand why we still providing mode: this.isEditable ? 'view' : 'edit' here and not component: 'interaction-designer',.

poojahpatil90 · 2021-08-25T21:14:28Z

Sorry for the late review here @poojahpatil90 , I'm approving.
I'd like to catchup with you about my question on route params later.
Thanks

@safydy-r Thanks for approving! I'll be happy to explain my thoughts behind these changes. Feel free to setup a call with me when it is convenient to you :)

poojahpatil90 added 2 commits April 25, 2021 23:29

Support deep linking for simulator

4ad932b

poojahpatil90 requested a review from bzabos April 27, 2021 04:47

poojahpatil90 changed the base branch from VMO-3703-deep-linking to VMO-3321-simulate-clipboard April 27, 2021 21:57

poojahpatil90 changed the base branch from VMO-3321-simulate-clipboard to VMO-3703-deep-linking April 27, 2021 21:58

Base automatically changed from VMO-3703-deep-linking to master May 27, 2021 17:42

poojahpatil90 changed the base branch from master to VMO-3321-simulate-clipboard June 1, 2021 22:29

poojahpatil90 added 3 commits June 1, 2021 18:37

Merge branch 'VMO-3321-simulate-clipboard' into VMO-3852-deep-linking…

3b70ffb

…-simulator # Conflicts: # src/components/interaction-designer/toolbar/TreeBuilderToolbar.vue # src/store/clipboard/index.ts # src/views/InteractionDesigner.vue # tests/unit/__snapshots__/storybook.spec.ts.snap

VMO-3852 Removing extra space

2d4b934

VMO-3852 Fix for TS error

1337084

poojahpatil90 changed the title ~~VMO-3852 Support deep linking for simulator~~ VMO-3852 Support deep linking for simulator + VMO-3687 Simulator on read only view Jun 8, 2021

poojahpatil90 requested review from safydy-r and removed request for bzabos June 16, 2021 01:26

safydy-r reviewed Jun 16, 2021

View reviewed changes

src/components/interaction-designer/toolbar/TreeBuilderToolbar.vue Outdated Show resolved Hide resolved

safydy-r reviewed Jun 16, 2021

View reviewed changes

Base automatically changed from VMO-3321-simulate-clipboard to master June 24, 2021 00:58

Merge branch 'master' into VMO-3852-deep-linking-simulator

6e5dfda

# Resolved Conflicts: # src/components/interaction-designer/toolbar/TreeBuilderToolbar.vue # src/views/InteractionDesigner.vue # tests/unit/__snapshots__/storybook.spec.ts.snap

github-actions bot reviewed Jun 29, 2021

View reviewed changes

VMO-3852 Updating snapshot

56985e5

poojahpatil90 requested a review from safydy-r August 10, 2021 16:45

Merge branch 'master' into VMO-3852-deep-linking-simulator

b31495d

# Resolved Conflicts: # src/components/interaction-designer/toolbar/TreeBuilderToolbar.vue # src/views/InteractionDesigner.vue # tests/unit/__snapshots__/storybook.spec.ts.snap

github-actions bot reviewed Aug 13, 2021

View reviewed changes

poojahpatil90 added 2 commits August 12, 2021 22:37

VMO-3852 Some minor fixes

30f23ed

Merge branch 'master' into VMO-3852-deep-linking-simulator

515bc99

# Resolved Conflicts: # src/views/InteractionDesigner.vue

github-actions bot reviewed Aug 24, 2021

View reviewed changes

safydy-r approved these changes Aug 25, 2021

View reviewed changes

		@@ -58,7 +64,7 @@ export const actions: ActionTree<IClipboardState, IRootState> = {
		},
		removeFromBlocksData({ state }, index: number) {

		@@ -38,6 +40,10 @@ export const mutations: MutationTree<IClipboardState> = {
		export const actions: ActionTree<IClipboardState, IRootState> = {
		setSimulatorActive({ commit }, value) {

		@@ -496,12 +495,7 @@ export default class TreeBuilderToolbar extends mixins(Routes, Permissions, Lang
		return (this.can('view-result-totals') && this.isFeatureViewResultsEnabled)

		@@ -221,6 +206,9 @@ export default {
		if (this.$route.meta?.isBlockEditorShown) {

Conversation

poojahpatil90 commented Apr 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

safydy-r Jun 16, 2021

Choose a reason for hiding this comment

Uh oh!

safydy-r Jun 16, 2021

Choose a reason for hiding this comment

Uh oh!

poojahpatil90 Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

safydy-r Aug 25, 2021

Choose a reason for hiding this comment

Uh oh!

safydy-r Jun 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

poojahpatil90 Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

safydy-r left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 29, 2021

Choose a reason for hiding this comment

poojahpatil90 commented Apr 27, 2021 •

edited

Loading

safydy-r Jun 16, 2021 •

edited

Loading