VMO-4787 Android user cannot download flows in an existing org#196
Open
VMO-4787 Android user cannot download flows in an existing org#196
Conversation
AlteaDown
approved these changes
Nov 3, 2021
Collaborator
AlteaDown
left a comment
AlteaDown
left a comment
There was a problem hiding this comment.
Approved, pending the changes we discussed.
safydy-r
reviewed
Nov 3, 2021
| // Redraw all connections related to that block: | ||
| // this.resetJsPlumbBindings(true, app.ui.mostRecentlyDeletedBlock.jsKey) | ||
|
|
||
| this.undoDeleteDecisionBranchBlockReferencesIfAny() |
Member
There was a problem hiding this comment.
@bulatgab , I'm curious how you identified the change should be in this legacy file ?
This is not called anywhere in the code as I know. https://github.com/FLOIP/flow-builder/blob/master/src/views/InteractionDesigner.vue#L56
Member
There was a problem hiding this comment.
sorry, I forgot to confirm this review last week, so it was still pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a block is deleted, clear any DecisionBranchBlock references to it