[iOS] add caretHeight and caretYoffset to TextInput component #37147#58
Open
OlimpiaZurek wants to merge 4 commits intoExpensify:ExpensifyRC1-0.72.0-alpha.0from
Open
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream PR Link
facebook#37147
Summary
This PR adds support for the
caretHeightandcaretPositionproperties in iOS multi-line TextInput. Based on these values, we can calculate the caret position and height and adjust them in the appl so that the cursor does not overlap the previous line of text.Changelog
[IOS] [ADDED] - caretHeight and caretPosition for multiline TextInput component
Test Plan
Default caret:
default_caret.mov
Caret with
caretHeightandcaretYOffsetadjustment:adjusting_caret.mov