fix: Not here page shown when navigate to Per Diem from the workspace editor#82196
fix: Not here page shown when navigate to Per Diem from the workspace editor#82196truph01 wants to merge 6 commits intoExpensify:mainfrom
Conversation
|
@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
Thanks @truph01! Ran your test steps and it worked. Screen.Recording.2026-02-12.at.3.01.54.PM.mov |
|
@shawnborton, could you trigger an ad-hoc build and see if it fixes the issue with your account? Thanks! |
|
Will do 👍 |
|
🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
CleanShot.2026-02-12.at.09.01.05.mp4 |
|
@shawnborton, thanks for testing! Should we
|
|
I think 1 above makes the most sense, I don't recall having any kind of commitment to those users, but let's see what @Expensify/product-pr thinks. |
JmillsExpensify
left a comment
There was a problem hiding this comment.
All good from a product perspective.
|
We are still waiting for confirmation from the design team before proceeding. |
|
I think we're good to proceed! |
|
...with option 1 from above. Thanks! |
|
Looks like we're waiting for PR updates following design confirmation. Let's jump on those early next week. |

Explanation of Change
Fixed Issues
$ #80872
PROPOSAL: #80872 (comment)
Tests
Prerequisite: Needs account with Control workspace and Per Diem feature enabled
/workspaces/{policyID}/overview/planand initiate a downgrade of the workspace plan.Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-02-12.at.04.01.46.mov
Android: mWeb Chrome
Screen.Recording.2026-02-12.at.04.05.56.mov
iOS: Native
Screen.Recording.2026-02-12.at.04.02.47.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-02-12.at.03.53.47.mov
Screen.Recording.2026-02-12.at.04.06.27.mov