MID-11094 Fix correlation case closing on resolution error#560
Open
MID-11094 Fix correlation case closing on resolution error#560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes correlation case completion so that failures in synchronization/import do not incorrectly close the case.
Previously, the case engine persisted the closing state before correlation-specific logic ran, causing cases to appear successfully closed even when the underlying projector/import failed.
This change introduces a two-phase lifecycle with a new prepareCaseClosing(...) hook executed before commit, where all retry-safe correlation logic is performed and explicitly fails on error, preventing the case from closing.
The existing finishCaseClosing(...) is kept for post-commit finalization only.
Correlation logic is refactored accordingly, including splitting shadow updates into pre-commit outcome data and post-success completion metadata, and ensuring errors recorded in OperationResult are propagated as exceptions.
As a result, failed correlation completion now leaves the case open and shows the correct business error, while successful behavior remains unchanged.