Conversation
Member
Author
|
With the changes here together with the change in ESCOMP/MOSART#126, the failing derecho-intel I compset tests are now passing with the recent ccs_config update: My next steps:
I'll mark this as ready for review once these things are done. |
ifx apparently doesn't do short-circuit evaluation, so SMS_D_Ld1.ne30pg3_t232.I1850Clm50BgcSpinup.derecho_intel.clm-cplhist was crashing with floating invalid when using the ifx compiler (via ccs_config_cesm1.0.75). Resolves ESCOMP#3763
Changed FillValue from NaN to non-Nan with: ncatted -a _FillValue,p_ac_MD,o,d,1.e38 /glade/campaign/cesm/cesmdata/inputdata/lnd/clm2/urbandata/CTSM52_urbantv_Li_2024_0.9x1.25_simyr1849-2106_c20260217.nc ncatted -a _FillValue,p_ac_HD,o,d,1.e38 /glade/campaign/cesm/cesmdata/inputdata/lnd/clm2/urbandata/CTSM52_urbantv_Li_2024_0.9x1.25_simyr1849-2106_c20260217.nc ncatted -a _FillValue,p_ac_TBD,o,d,1.e38 /glade/campaign/cesm/cesmdata/inputdata/lnd/clm2/urbandata/CTSM52_urbantv_Li_2024_0.9x1.25_simyr1849-2106_c20260217.nc Partially addresses ESCOMP#3764
Fixed by first setting _FillValue to NaN, then setting _FillValue to the original missing value, via: ncatted -a _FillValue,Z0a,o,d,NaN Prigent_2005_roughness_0.25x0.25_cdf5_c260218.nc ncatted -a _FillValue,Z0a,o,d,1.e32 Prigent_2005_roughness_0.25x0.25_cdf5_c260218.nc Partially addresses ESCOMP#3764
5fd69ab to
c7230f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
(1) ifx apparently doesn't do short-circuit evaluation, so SMS_D_Ld1.ne30pg3_t232.I1850Clm50BgcSpinup.derecho_intel.clm-cplhist was crashing with floating invalid when using the ifx compiler (via ccs_config_cesm1.0.75).
(2) Some input files need NaNs converted to non-NaN fill values
Specific notes
Contributors other than yourself, if any: @jedwards4b
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)?
Does this create a need to change or add documentation? Did you do so?
Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)
NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).