pasted changes from my rework in Acoustics_V2#21
Open
Saagar-Arya wants to merge 1 commit intomainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the neural network training script to make feature columns and confidence thresholds configurable via command-line arguments, replacing previously hardcoded values.
Changes:
- Feature columns are now passed dynamically via
--feature_colsCLI arg and propagated toHydrophoneDataset, removing hardcodedEnvelope H1/H2/H3index lookups. - Confidence thresholds are configurable via
--conf_threshCLI arg, replacing hardcoded 50%/80% thresholds with a loop over user-specified values. - Cleaned up commented-out code for different
in_dimconfigurations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+69
to
+73
| missing = [name for name in features_list if name not in col_idx] | ||
|
|
||
| if missing: | ||
| raise ValueError(f"CSV missing requested feature columns: {missing}") | ||
|
|
| # def __init__(self, in_dim=1, num_classes=4, p_drop=0.2): | ||
| # def __init__(self, in_dim=2, num_classes=4, p_drop=0.2): | ||
|
|
||
| def __init__(self, in_dim=3, num_classes=4, p_drop=0.2): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.