Standardize CLI terminal output: separator widths and missing emojis#84
Standardize CLI terminal output: separator widths and missing emojis#84
Conversation
Co-authored-by: ewega <26189114+ewega@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Standardizes the CLI’s terminal output formatting to better match the repository’s terminal UX conventions by aligning summary separator widths and adding emoji-prefixed section headers where they were missing.
Changes:
- Normalize summary separators from 50 to 40 characters across multiple configure/status flows.
- Add emoji prefixes to previously plain section headers in Azure deploy/cleanup output.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/status.go | Adjusts the status section separator width to 40. |
| cmd/deploy_azure.go | Adds 📋 emoji to the “Configuration” header. |
| cmd/configure_scope_delete.go | Updates summary separator width to 40. |
| cmd/configure_scope_add.go | Updates summary separator width to 40. |
| cmd/configure_projects.go | Updates project finalization summary separator width to 40. |
| cmd/configure_project_delete.go | Updates delete summary separator width to 40. |
| cmd/configure_full.go | Updates connection-setup summary separator widths to 40. |
| cmd/configure_connection_update.go | Updates update summary separator width to 40. |
| cmd/configure_connection_delete.go | Updates delete summary separator width to 40. |
| cmd/configure_connection_add.go | Updates add summary separator width to 40. |
| cmd/cleanup.go | Adds emoji-prefixed headers for deployment/resources/endpoints sections. |
| fmt.Printf(" Plugin: %s\n", pn) | ||
| } | ||
| fmt.Println(strings.Repeat("\u2500", 50)) | ||
| fmt.Println(strings.Repeat("\u2500", 40)) |
There was a problem hiding this comment.
This summary block ends with a closing separator and then returns without printing a trailing blank line. Terminal Output Standards recommend a blank line after separators so the shell prompt (or subsequent output) doesn’t jam against the separator. Consider printing a final blank line after the closing separator here.
| fmt.Println(strings.Repeat("\u2500", 40)) | |
| fmt.Println(strings.Repeat("\u2500", 40)) | |
| fmt.Println() |
| fmt.Println("\n" + strings.Repeat("─", 40)) | ||
| fmt.Println("⚠️ No connections were created.") | ||
| fmt.Println(strings.Repeat("─", 50)) | ||
| fmt.Println(strings.Repeat("─", 40)) |
There was a problem hiding this comment.
In the len(results) == 0 branch, the summary separator block ends and the function returns an error immediately. Per Terminal Output Standards (blank line after separators), this will cause the subsequent error message printed by Execute() to appear directly under the separator with no breathing room. Add an extra blank line after the closing separator (or ensure the next output starts with a blank line) before returning.
| fmt.Println(strings.Repeat("─", 40)) | |
| fmt.Println(strings.Repeat("─", 40)) | |
| fmt.Println() |
|
@copilot apply changes based on the comments in this thread |
… standards Co-authored-by: ewega <26189114+ewega@users.noreply.github.com>
Applied both review suggestions in |
cmd/status.go
Outdated
|
|
||
| printBanner("DevLake Status") | ||
| sep := " " + strings.Repeat("─", 42) | ||
| sep := " " + strings.Repeat("─", 40) |
There was a problem hiding this comment.
sep is built as two leading spaces plus 40 box-drawing characters, so the visible separator line is 42 chars wide. If the goal is to standardize separators to 40 (matching the banner width convention), either drop the indent or reduce the repeat count so the total width is 40.
| sep := " " + strings.Repeat("─", 40) | |
| sep := " " + strings.Repeat("─", 38) |
| fmt.Printf(" %-18s ID=%d %q\n", name, r.ConnectionID, r.Name) | ||
| } | ||
| fmt.Println(strings.Repeat("─", 50)) | ||
| fmt.Println(strings.Repeat("─", 40)) |
There was a problem hiding this comment.
The success summary returns immediately after printing the closing separator, so there’s no trailing blank line. Terminal output standards require a blank line after separators; add a final empty line after the closing separator here as well (matching the len(results)==0 branch).
| fmt.Println(strings.Repeat("─", 40)) | |
| fmt.Println(strings.Repeat("─", 40)) | |
| fmt.Println() |
|
@copilot apply changes based on the comments in this thread |
… blank line in configure_full.go success path Co-authored-by: ewega <26189114+ewega@users.noreply.github.com>
Applied both review suggestions in
|
printBannerwidth convention" " + Repeat("─", 38)so total visible width = 40configure_projects.go,configure_full.go(both branches) per terminal output standardsOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.