Skip to content

Added top padding to home #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JorimTheuns wants to merge 1 commit into
base: testing
Choose a base branch
from
+5 −1
Open

Added top padding to home #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions echo/docs/style-guides/frontend_spacing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,10 @@ Standard page padding should be responsive:
</Stack>
```

## Default Boldness

When making spacing changes, prefer bold, visually obvious values over subtle ones. For example, when adding top padding to a page container, use a large value like `pt="8rem"` rather than a subtle `pt="md"`. Spacing should feel intentional and impactful — not barely noticeable. When in doubt, go bigger.

## Notes

- Use fixed gap values as they don't support responsive parameters
Expand Down
2 changes: 1 addition & 1 deletion echo/frontend/src/routes/project/ProjectsHome.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export const ProjectsHomeRoute = () => {
)?.flatMap((page) => page.projects) ?? [];

return (
<Container>
<Container pt="8rem">
<Stack>
<Group justify="space-between">
<Group align="center">
Expand Down
Loading